Skip to content

i18n and new client_side_replay:true might not work together #952

@ssairanen

Description

@ssairanen

Describe the bug

client_side_replay:true might not work when i18n url component is on. (https://github.com/webrecorder/pywb/blob/main/docs/manual/localization.rst#localized-collection-paths)

Steps to reproduce the bug

I was testing if warcs extracted out of wacz file might work in new client_side_replay:true mode, and they in fact were working all good.

I also was testing the new i18n feature, and I noticed that the "more advanced part" (javascript stuffs) of the page is not working whenever the .../locale/... was on.

Expected behavior

There shouldn't be any difference in replay with or without localized collection paths?

Screenshots

Page without localization path:
Image

Page with localization path:
Image

Environment

Firefox 140.0.4
Linux

Additional context

In the service workers' IndexedDB config.extraConfig.archivePrefix/baseUrl gets this localization path added, sometimes not, depending probably if you have localization on when you first time go to the collection or not. Could this have something to do with it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions