Skip to content

Client-side replay: head_insert.html and header.html template overrides broken #955

@obrienben

Description

@obrienben

Describe the bug

In client_side_replay mode in Pywb v2.9.0, local template overrides no longer work for head_insert.html and header.html.
When client_side_replay mode is disabled in v2.9.0, then these overrides function again.

Suspect this is due to client side replay loading this code from a different source. The wabacSW.js library that the mode uses, from wabac.js project, contains head_insert.html code in collection.ts.

Steps to reproduce the bug

Install Pywb v2.9.0.
Enable Client-side Replay mode in local config.yaml
Create local templates directory, and run wb-manager template --add head_insert_html
Edit head_insert.html inside templates/, add something that would be visible when viewing the frame source

Expected behavior

head_insert.html and header.html can be overridden with local template copies for custom behavior, as they could be prior to v2.9.0

Screenshots

Environment

  • OS: Ubuntu 24
  • Browser: Chrome, Firefox

Additional context

Have tested versions 2.8.4, 2.8.3 and 2.7.4 of Pywb, and overrides still work for these as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions