fix clippy warnings

Author: algesten

src/compound_packet/compound_packet_test.rs

@@ -151,7 +151,7 @@ fn test_valid_packet() {
             "goodbye",
             CompoundPacket(vec![
                 Box::new(ReceiverReport::default()),
-                Box::new(cname.clone()),
+                Box::new(cname),
                 Box::new(Goodbye::default()),
             ]),
             None,
@@ -237,7 +237,7 @@ fn test_cname() {
             "goodbye",
             CompoundPacket(vec![
                 Box::new(ReceiverReport::default()),
-                Box::new(cname.clone()),
+                Box::new(cname),
                 Box::new(Goodbye::default()),
             ]),
             None,
@@ -286,7 +286,7 @@ fn test_compound_packet_roundtrip() {
             "goodbye",
             CompoundPacket(vec![
                 Box::new(ReceiverReport::default()),
-                Box::new(cname.clone()),
+                Box::new(cname),
                 Box::new(Goodbye {
                     sources: vec![1234],
                     ..Default::default()
@@ -320,11 +320,11 @@ fn test_compound_packet_roundtrip() {
 
         let data1 = result.unwrap();
         let c = CompoundPacket::unmarshal(&mut data1.clone())
-            .expect(format!("unmarshal {} error", name).as_str());
+            .unwrap_or_else(|_| panic!("unmarshal {} error", name));
 
         let data2 = c
             .marshal()
-            .expect(format!("marshal {} error", name).as_str());
+            .unwrap_or_else(|_| panic!("marshal {} error", name));
 
         assert_eq!(
             data1, data2,

src/goodbye/goodbye_test.rs

@@ -186,7 +186,7 @@ fn test_goodbye_round_trip() {
         (
             "count overflow",
             Goodbye {
-                sources: too_many_sources.clone(),
+                sources: too_many_sources,
                 reason: Bytes::from_static(b""),
             },
             Some(Error::TooManySources),
@@ -223,7 +223,7 @@ fn test_goodbye_round_trip() {
         } else {
             let mut data = got.ok().unwrap();
             let actual =
-                Goodbye::unmarshal(&mut data).expect(format!("Unmarshal {}", name).as_str());
+                Goodbye::unmarshal(&mut data).unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
             assert_eq!(
                 actual, want,

src/header.rs

@@ -313,7 +313,8 @@ mod test {
             } else {
                 let data = got.ok().unwrap();
                 let buf = &mut data.clone();
-                let actual = Header::unmarshal(buf).expect(format!("Unmarshal {}", name).as_str());
+                let actual =
+                    Header::unmarshal(buf).unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
                 assert_eq!(
                     actual, want,

src/packet.rs

@@ -56,10 +56,10 @@ where
 
     match packets.len() {
         // Empty Packet
-        0 => Err(Error::InvalidHeader.into()),
+        0 => Err(Error::InvalidHeader),
 
         // Single Packet
-        1 => packets.pop().ok_or_else(|| Error::BadFirstPacket.into()),
+        1 => packets.pop().ok_or(Error::BadFirstPacket),
 
         // Compound Packet
         _ => Ok(Box::new(CompoundPacket(packets))),
@@ -76,7 +76,7 @@ where
 
     let length = (h.length as usize) * 4;
     if length > raw_data.remaining() {
-        return Err(Error::PacketTooShort.into());
+        return Err(Error::PacketTooShort);
     }
 
     let mut in_packet = h.marshal()?.chain(raw_data.take(length));

src/payload_feedbacks/full_intra_request/full_intra_request_test.rs

@@ -172,7 +172,7 @@ fn test_full_intra_request_round_trip() {
         } else {
             let mut data = got.ok().unwrap();
             let actual = FullIntraRequest::unmarshal(&mut data)
-                .expect(format!("Unmarshal {}", name).as_str());
+                .unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
             assert_eq!(
                 actual, want,

src/payload_feedbacks/picture_loss_indication/picture_loss_indication_test.rs

@@ -126,7 +126,7 @@ fn test_picture_loss_indication_roundtrip() {
         } else {
             let mut data = got.ok().unwrap();
             let actual = PictureLossIndication::unmarshal(&mut data)
-                .expect(format!("Unmarshal {}", name).as_str());
+                .unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
             assert_eq!(
                 actual, want,

src/payload_feedbacks/receiver_estimated_maximum_bitrate/receiver_estimated_maximum_bitrate_test.rs

@@ -158,7 +158,7 @@ fn test_receiver_estimated_maximum_bitrate_roundtrip() {
 
         let mut data = got.ok().unwrap();
         let actual = ReceiverEstimatedMaximumBitrate::unmarshal(&mut data)
-            .expect(format!("Unmarshal {}", name).as_str());
+            .unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
         if let Some(expected_bitrate) = unmarshal_expected {
             assert_eq!(

src/payload_feedbacks/slice_loss_indication/slice_loss_indication_test.rs

@@ -132,7 +132,7 @@ fn test_slice_loss_indication_roundtrip() {
         } else {
             let mut data = got.ok().unwrap();
             let actual = SliceLossIndication::unmarshal(&mut data)
-                .expect(format!("Unmarshal {}", name).as_str());
+                .unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
             assert_eq!(
                 actual, want,

src/receiver_report/receiver_report_test.rs

@@ -239,8 +239,8 @@ fn test_receiver_report_roundtrip() {
             );
         } else {
             let mut data = got.ok().unwrap();
-            let actual =
-                ReceiverReport::unmarshal(&mut data).expect(format!("Unmarshal {}", name).as_str());
+            let actual = ReceiverReport::unmarshal(&mut data)
+                .unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
             assert_eq!(
                 actual, want,

src/sender_report/sender_report_test.rs

@@ -250,7 +250,7 @@ fn test_sender_report_roundtrip() {
         } else {
             let mut data = got.ok().unwrap();
             let actual =
-                SenderReport::unmarshal(&mut data).expect(format!("Unmarshal {}", name).as_str());
+                SenderReport::unmarshal(&mut data).unwrap_or_else(|_| panic!("Unmarshal {}", name));
 
             assert_eq!(
                 actual, want,