make packet trait as Send + Sync

Author: Rain Liu

src/compound_packet/mod.rs

@@ -25,7 +25,7 @@ use std::fmt;
 ///
 /// Other RTCP packet types may follow in any order. Packet types may appear more than once.
 #[derive(Debug, Default, PartialEq, Clone)]
-pub struct CompoundPacket(pub Vec<Box<dyn Packet>>);
+pub struct CompoundPacket(pub Vec<Box<dyn Packet + Send + Sync>>);
 
 impl fmt::Display for CompoundPacket {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
@@ -60,14 +60,14 @@ impl Packet for CompoundPacket {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<CompoundPacket>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/goodbye/mod.rs

@@ -57,14 +57,14 @@ impl Packet for Goodbye {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<Goodbye>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/packet.rs

@@ -21,18 +21,18 @@ pub trait Packet: Marshal + Unmarshal + fmt::Display + fmt::Debug {
     fn destination_ssrc(&self) -> Vec<u32>;
     fn raw_size(&self) -> usize;
     fn as_any(&self) -> &dyn Any;
-    fn equal(&self, other: &dyn Packet) -> bool;
-    fn cloned(&self) -> Box<dyn Packet>;
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool;
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync>;
 }
 
-impl PartialEq for dyn Packet {
+impl PartialEq for dyn Packet + Send + Sync {
     fn eq(&self, other: &Self) -> bool {
         self.equal(other)
     }
 }
 
-impl Clone for Box<dyn Packet> {
-    fn clone(&self) -> Box<dyn Packet> {
+impl Clone for Box<dyn Packet + Send + Sync> {
+    fn clone(&self) -> Box<dyn Packet + Send + Sync> {
         self.cloned()
     }
 }
@@ -43,7 +43,7 @@ impl Clone for Box<dyn Packet> {
 /// If this is a reduced-size RTCP packet a feedback packet (Goodbye, SliceLossIndication, etc)
 /// will be returned. Otherwise, the underlying type of the returned packet will be
 /// CompoundPacket.
-pub fn unmarshal<B>(raw_data: &mut B) -> Result<Box<dyn Packet>>
+pub fn unmarshal<B>(raw_data: &mut B) -> Result<Box<dyn Packet + Send + Sync>>
 where
     B: Buf,
 {
@@ -68,7 +68,7 @@ where
 
 /// unmarshaller is a factory which pulls the first RTCP packet from a bytestream,
 /// and returns it's parsed representation, and the amount of data that was processed.
-pub(crate) fn unmarshaller<B>(raw_data: &mut B) -> Result<Box<dyn Packet>>
+pub(crate) fn unmarshaller<B>(raw_data: &mut B) -> Result<Box<dyn Packet + Send + Sync>>
 where
     B: Buf,
 {
@@ -81,7 +81,7 @@ where
 
     let mut in_packet = h.marshal()?.chain(raw_data.take(length));
 
-    let p: Box<dyn Packet> = match h.packet_type {
+    let p: Box<dyn Packet + Send + Sync> = match h.packet_type {
         PacketType::SenderReport => Box::new(SenderReport::unmarshal(&mut in_packet)?),
         PacketType::ReceiverReport => Box::new(ReceiverReport::unmarshal(&mut in_packet)?),
         PacketType::SourceDescription => Box::new(SourceDescription::unmarshal(&mut in_packet)?),
@@ -185,7 +185,7 @@ mod test {
             media_ssrc: 0x902f9e2e,
         };
 
-        let expected: Box<dyn Packet> = Box::new(CompoundPacket(vec![
+        let expected: Box<dyn Packet + Send + Sync> = Box::new(CompoundPacket(vec![
             Box::new(a),
             Box::new(b),
             Box::new(c),

src/payload_feedbacks/full_intra_request/mod.rs

@@ -65,14 +65,14 @@ impl Packet for FullIntraRequest {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<FullIntraRequest>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/payload_feedbacks/picture_loss_indication/mod.rs

@@ -54,14 +54,14 @@ impl Packet for PictureLossIndication {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<PictureLossIndication>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/payload_feedbacks/receiver_estimated_maximum_bitrate/mod.rs

@@ -76,14 +76,14 @@ impl Packet for ReceiverEstimatedMaximumBitrate {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<ReceiverEstimatedMaximumBitrate>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/payload_feedbacks/slice_loss_indication/mod.rs

@@ -69,14 +69,14 @@ impl Packet for SliceLossIndication {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<SliceLossIndication>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/raw_packet.rs

@@ -40,14 +40,14 @@ impl Packet for RawPacket {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<RawPacket>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/receiver_report/mod.rs

@@ -73,14 +73,14 @@ impl Packet for ReceiverReport {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<ReceiverReport>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }

src/reception_report.rs

@@ -70,14 +70,14 @@ impl Packet for ReceptionReport {
         self
     }
 
-    fn equal(&self, other: &dyn Packet) -> bool {
+    fn equal(&self, other: &(dyn Packet + Send + Sync)) -> bool {
         other
             .as_any()
             .downcast_ref::<ReceptionReport>()
             .map_or(false, |a| self == a)
     }
 
-    fn cloned(&self) -> Box<dyn Packet> {
+    fn cloned(&self) -> Box<dyn Packet + Send + Sync> {
         Box::new(self.clone())
     }
 }