general: apply clippy lints (#407)

* general: update crates to 2021 edition.

* general: apply clippy --fix

* general: apply manual clippy lints

* cargo fmt.

Author: jxs

constraints/Cargo.toml

@@ -2,7 +2,7 @@
 name = "webrtc-constraints"
 version = "0.1.0"
 authors = ["Vincent Esche <[email protected]>"]
-edition = "2018"
+edition = "2021"
 description = "A pure Rust implementation of WebRTC Media Constraints API"
 license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-constraints"

constraints/src/algorithms/fitness_distance/setting.rs

@@ -345,10 +345,10 @@ mod tests {
 
                     let expected = 0.0;
 
-                    println!("constraint: {:?}", constraint);
-                    println!("setting: {:?}", setting);
-                    println!("actual: {:?}", actual);
-                    println!("expected: {:?}", expected);
+                    println!("constraint: {constraint:?}");
+                    println!("setting: {setting:?}");
+                    println!("actual: {actual:?}");
+                    println!("expected: {expected:?}");
 
                     assert_eq!(actual, expected);
                 }
@@ -434,10 +434,10 @@ mod tests {
 
                 let expected = 0.0;
 
-                println!("constraint: {:?}", constraint);
-                println!("setting: {:?}", setting);
-                println!("actual: {:?}", actual);
-                println!("expected: {:?}", expected);
+                println!("constraint: {constraint:?}");
+                println!("setting: {setting:?}");
+                println!("actual: {actual:?}");
+                println!("expected: {expected:?}");
 
                 assert_eq!(actual, expected);
             }

constraints/src/constraint/value.rs

@@ -197,14 +197,14 @@ where
         let mut is_first = true;
         f.write_str("(")?;
         if let Some(ref exact) = &self.exact {
-            f.write_fmt(format_args!("x == {:?}", exact))?;
+            f.write_fmt(format_args!("x == {exact:?}"))?;
             is_first = false;
         }
         if let Some(ref ideal) = &self.ideal {
             if !is_first {
                 f.write_str(" && ")?;
             }
-            f.write_fmt(format_args!("x ~= {:?}", ideal))?;
+            f.write_fmt(format_args!("x ~= {ideal:?}"))?;
             is_first = false;
         }
         if is_first {

constraints/src/constraint/value_range.rs

@@ -233,23 +233,23 @@ where
         let mut is_first = true;
         f.write_str("(")?;
         if let Some(exact) = &self.exact {
-            f.write_fmt(format_args!("x == {:?}", exact))?;
+            f.write_fmt(format_args!("x == {exact:?}"))?;
             is_first = false;
         } else if let (Some(min), Some(max)) = (&self.min, &self.max) {
-            f.write_fmt(format_args!("{:?} <= x <= {:?}", min, max))?;
+            f.write_fmt(format_args!("{min:?} <= x <= {max:?}"))?;
             is_first = false;
         } else if let Some(min) = &self.min {
-            f.write_fmt(format_args!("{:?} <= x", min))?;
+            f.write_fmt(format_args!("{min:?} <= x"))?;
             is_first = false;
         } else if let Some(max) = &self.max {
-            f.write_fmt(format_args!("x <= {:?}", max))?;
+            f.write_fmt(format_args!("x <= {max:?}"))?;
             is_first = false;
         }
         if let Some(ideal) = &self.ideal {
             if !is_first {
                 f.write_str(" && ")?;
             }
-            f.write_fmt(format_args!("x ~= {:?}", ideal))?;
+            f.write_fmt(format_args!("x ~= {ideal:?}"))?;
             is_first = false;
         }
         if is_first {

constraints/src/constraint/value_sequence.rs

@@ -204,14 +204,14 @@ where
         let mut is_first = true;
         f.write_str("(")?;
         if let Some(ref exact) = &self.exact {
-            f.write_fmt(format_args!("x == {:?}", exact))?;
+            f.write_fmt(format_args!("x == {exact:?}"))?;
             is_first = false;
         }
         if let Some(ref ideal) = &self.ideal {
             if !is_first {
                 f.write_str(" && ")?;
             }
-            f.write_fmt(format_args!("x ~= {:?}", ideal))?;
+            f.write_fmt(format_args!("x ~= {ideal:?}"))?;
             is_first = false;
         }
         if is_first {

constraints/src/errors.rs

@@ -31,7 +31,7 @@ impl std::fmt::Display for OverconstrainedError {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         write!(f, "Overconstrained property {:?}", self.constraint)?;
         if let Some(message) = self.message.as_ref() {
-            write!(f, ": {}", message)?;
+            write!(f, ": {message}")?;
         }
         Ok(())
     }
@@ -100,10 +100,10 @@ impl OverconstrainedError {
             [reason] => reason.clone(),
             [reasons @ .., reason] => {
                 let reasons = reasons.join(", ");
-                format!("either {}, or {}", reasons, reason)
+                format!("either {reasons}, or {reason}")
             }
         };
-        let message = Some(format!("Setting was {}.", formatted_reason));
+        let message = Some(format!("Setting was {formatted_reason}."));
 
         Self {
             constraint,

constraints/src/setting.rs

@@ -28,10 +28,10 @@ pub enum MediaTrackSetting {
 impl std::fmt::Display for MediaTrackSetting {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
-            Self::Bool(setting) => f.write_fmt(format_args!("{:?}", setting)),
-            Self::Integer(setting) => f.write_fmt(format_args!("{:?}", setting)),
-            Self::Float(setting) => f.write_fmt(format_args!("{:?}", setting)),
-            Self::String(setting) => f.write_fmt(format_args!("{:?}", setting)),
+            Self::Bool(setting) => f.write_fmt(format_args!("{setting:?}")),
+            Self::Integer(setting) => f.write_fmt(format_args!("{setting:?}")),
+            Self::Float(setting) => f.write_fmt(format_args!("{setting:?}")),
+            Self::String(setting) => f.write_fmt(format_args!("{setting:?}")),
         }
     }
 }

data/Cargo.toml

@@ -2,7 +2,7 @@
 name = "webrtc-data"
 version = "0.6.0"
 authors = ["Rain Liu <[email protected]>"]
-edition = "2018"
+edition = "2021"
 description = "A pure Rust implementation of WebRTC DataChannel API"
 license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-data"

dtls/Cargo.toml

@@ -2,7 +2,7 @@
 name = "webrtc-dtls"
 version = "0.7.0"
 authors = ["Rain Liu <[email protected]>"]
-edition = "2018"
+edition = "2021"
 description = "A pure Rust implementation of DTLS"
 license = "MIT/Apache-2.0"
 documentation = "https://docs.rs/webrtc-dtls"

dtls/examples/dial/psk/dial_psk.rs

@@ -57,7 +57,7 @@ async fn main() -> Result<(), Error> {
 
     let conn = Arc::new(UdpSocket::bind("0.0.0.0:0").await?);
     conn.connect(server).await?;
-    println!("connecting {}..", server);
+    println!("connecting {server}..");
 
     let config = Config {
         psk: Some(Arc::new(|hint: &[u8]| -> Result<Vec<u8>, Error> {