Skip to content

Commit e5baba1

Browse files
Use MissedTickBehavior::Skip for TWCC ticker (#323)
1 parent 60f4c43 commit e5baba1

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

interceptor/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Unreleased
44

55
* Further extended stats interceptors to collect stats for `RemoteOutoundRTPStats` and improve `RemoteInboundRTPStats` collection. [#282](https://github.com/webrtc-rs/webrtc/pull/282) by [@k0nserv](https://github.com/k0nserv).
6+
* When generating periodic TWCC feedback packets we no longer burst several packets in a row to catch up, i.e., we now use `MissedTickBehavior::Skip` instead of the default `MissedTickBehavior::Burst` for the ticker in question. [#323](https://github.com/webrtc-rs/webrtc/pull/323) by [@k0nserv](https://github.com/k0nserv).
67

78
## v0.8.0
89

interceptor/src/twcc/receiver/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use receiver_stream::ReceiverStream;
1010
use rtp::extension::transport_cc_extension::TransportCcExtension;
1111
use std::time::{Duration, SystemTime};
1212
use tokio::sync::{mpsc, Mutex};
13+
use tokio::time::MissedTickBehavior;
1314
use util::Unmarshal;
1415
use waitgroup::WaitGroup;
1516

@@ -112,6 +113,7 @@ impl Receiver {
112113

113114
let a = Attributes::new();
114115
let mut ticker = tokio::time::interval(internal.interval);
116+
ticker.set_missed_tick_behavior(MissedTickBehavior::Skip);
115117
loop {
116118
tokio::select! {
117119
_ = close_rx.recv() =>{

0 commit comments

Comments
 (0)