fix clippy

Author: yngrtc

ice/src/agent/agent_transport_test.rs

@@ -13,22 +13,14 @@ pub(crate) async fn pipe(
     let (a_notifier, mut a_connected) = on_connected();
     let (b_notifier, mut b_connected) = on_connected();
 
-    let mut cfg0 = if let Some(cfg) = default_config0 {
-        cfg
-    } else {
-        AgentConfig::default()
-    };
+    let mut cfg0 = default_config0.unwrap_or_default();
     cfg0.urls = vec![];
     cfg0.network_types = supported_network_types();
 
     let a_agent = Arc::new(Agent::new(cfg0).await?);
     a_agent.on_connection_state_change(a_notifier);
 
-    let mut cfg1 = if let Some(cfg) = default_config1 {
-        cfg
-    } else {
-        AgentConfig::default()
-    };
+    let mut cfg1 = default_config1.unwrap_or_default();
     cfg1.urls = vec![];
     cfg1.network_types = supported_network_types();
 

interceptor/src/nack/generator/mod.rs

@@ -61,11 +61,7 @@ impl InterceptorBuilder for GeneratorBuilder {
                 } else {
                     13 - 6 // 8192 = 1 << 13
                 },
-                skip_last_n: if let Some(skip_last_n) = self.skip_last_n {
-                    skip_last_n
-                } else {
-                    0
-                },
+                skip_last_n: self.skip_last_n.unwrap_or_default(),
                 interval: if let Some(interval) = self.interval {
                     interval
                 } else {

media/src/audio/buffer.rs

@@ -123,7 +123,7 @@ where
             );
 
             // Transmute the vec to the initialized type.
-            unsafe { std::mem::transmute::<_, Vec<T>>(samples) }
+            unsafe { std::mem::transmute::<Vec<MaybeUninit<T>>, Vec<T>>(samples) }
         };
 
         let info = buffer.info.into();
@@ -167,7 +167,7 @@ where
             );
 
             // Everything is initialized. Transmute the vec to the initialized type.
-            unsafe { std::mem::transmute::<_, Vec<T>>(samples) }
+            unsafe { std::mem::transmute::<Vec<MaybeUninit<T>>, Vec<T>>(samples) }
         };
 
         let info = buffer.info.into();

rtcp/src/payload_feedbacks/slice_loss_indication/mod.rs

@@ -97,7 +97,7 @@ impl MarshalSize for SliceLossIndication {
 impl Marshal for SliceLossIndication {
     /// Marshal encodes the SliceLossIndication in binary
     fn marshal_to(&self, mut buf: &mut [u8]) -> Result<usize> {
-        if (self.sli_entries.len() + SLI_LENGTH) as u8 > std::u8::MAX {
+        if (self.sli_entries.len() + SLI_LENGTH) as u8 > u8::MAX {
             return Err(Error::TooManyReports.into());
         }
         if buf.remaining_mut() < self.marshal_size() {

rtcp/src/transport_feedbacks/transport_layer_cc/mod.rs

@@ -323,15 +323,15 @@ impl MarshalSize for RecvDelta {
         // small delta
         if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedSmallDelta
             && delta >= 0
-            && delta <= std::u8::MAX as i64
+            && delta <= u8::MAX as i64
         {
             return 1;
         }
 
         // big delta
         if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedLargeDelta
-            && delta >= std::i16::MIN as i64
-            && delta <= std::u16::MAX as i64
+            && delta >= i16::MIN as i64
+            && delta <= u16::MAX as i64
         {
             return 2;
         }
@@ -348,7 +348,7 @@ impl Marshal for RecvDelta {
         // small delta
         if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedSmallDelta
             && delta >= 0
-            && delta <= std::u8::MAX as i64
+            && delta <= u8::MAX as i64
             && buf.remaining_mut() >= 1
         {
             buf.put_u8(delta as u8);
@@ -357,8 +357,8 @@ impl Marshal for RecvDelta {
 
         // big delta
         if self.type_tcc_packet == SymbolTypeTcc::PacketReceivedLargeDelta
-            && delta >= std::i16::MIN as i64
-            && delta <= std::u16::MAX as i64
+            && delta >= i16::MIN as i64
+            && delta <= u16::MAX as i64
             && buf.remaining_mut() >= 2
         {
             buf.put_u16(delta as u16);

rtcp/src/transport_feedbacks/transport_layer_nack/mod.rs

@@ -173,7 +173,7 @@ impl MarshalSize for TransportLayerNack {
 impl Marshal for TransportLayerNack {
     /// Marshal encodes the packet in binary.
     fn marshal_to(&self, mut buf: &mut [u8]) -> Result<usize, util::Error> {
-        if self.nacks.len() + TLN_LENGTH > std::u8::MAX as usize {
+        if self.nacks.len() + TLN_LENGTH > u8::MAX as usize {
             return Err(Error::TooManyReports.into());
         }
         if buf.remaining_mut() < self.marshal_size() {