Skip to content

Commit fb3f05a

Browse files
WandalenWandalen
committed
chore: Remove validation debug logging
- Comment out verbose validation logs in start_rtp() - Comment out verbose validation logs in start_rtp_receivers() - Remove track filtering debug output - Remove transceiver matching debug output
1 parent 858fd6c commit fb3f05a

File tree

1 file changed

+41
-41
lines changed

1 file changed

+41
-41
lines changed

‎webrtc/src/peer_connection/peer_connection_internal.rs‎

Lines changed: 41 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -285,17 +285,17 @@ impl PeerConnectionInternal {
285285
}
286286

287287
// VALIDATION LOGGING: H15 (incoming_tracks empty?) and H14 (transceiver list)
288-
log::info!("🔍 VALIDATION: start_rtp() called, is_renegotiation={}", is_renegotiation);
289-
log::info!("🔍 VALIDATION: incoming_tracks.len() = {}", track_details.len());
290-
for (i, track) in track_details.iter().enumerate() {
291-
log::info!("🔍 VALIDATION: incoming_track[{}]: mid={}, kind={:?}, ssrcs={:?}",
292-
i, track.mid, track.kind, track.ssrcs);
293-
}
294-
log::info!("🔍 VALIDATION: current_transceivers.len() = {}", current_transceivers.len());
295-
for (i, t) in current_transceivers.iter().enumerate() {
296-
log::info!("🔍 VALIDATION: transceiver[{}]: mid={:?}, kind={:?}, direction={:?}",
297-
i, t.mid(), t.kind(), t.direction());
298-
}
288+
// log::info!("🔍 VALIDATION: start_rtp() called, is_renegotiation={}", is_renegotiation);
289+
// log::info!("🔍 VALIDATION: incoming_tracks.len() = {}", track_details.len());
290+
// for (i, track) in track_details.iter().enumerate() {
291+
// log::info!("🔍 VALIDATION: incoming_track[{}]: mid={}, kind={:?}, ssrcs={:?}",
292+
// i, track.mid, track.kind, track.ssrcs);
293+
// }
294+
// log::info!("🔍 VALIDATION: current_transceivers.len() = {}", current_transceivers.len());
295+
// for (i, t) in current_transceivers.iter().enumerate() {
296+
// log::info!("🔍 VALIDATION: transceiver[{}]: mid={:?}, kind={:?}, direction={:?}",
297+
// i, t.mid(), t.kind(), t.direction());
298+
// }
299299

300300
self.start_rtp_receivers(&mut track_details, &current_transceivers, is_renegotiation)
301301
.await?;
@@ -435,68 +435,68 @@ impl PeerConnectionInternal {
435435
) -> Result<()> {
436436
// Ensure we haven't already started a transceiver for this ssrc
437437
// SKIP filtering during renegotiation - let receiver reset logic handle it
438-
log::info!("🔍 VALIDATION: start_rtp_receivers() - incoming_tracks.len()={}, is_renegotiation={}", incoming_tracks.len(), is_renegotiation);
438+
// log::info!("🔍 VALIDATION: start_rtp_receivers() - incoming_tracks.len()={}, is_renegotiation={}", incoming_tracks.len(), is_renegotiation);
439439
let mut filtered_tracks = incoming_tracks.clone();
440440

441441
if !is_renegotiation {
442-
log::info!("🔍 VALIDATION: Filtering tracks (initial negotiation)");
442+
// log::info!("🔍 VALIDATION: Filtering tracks (initial negotiation)");
443443
for incoming_track in incoming_tracks {
444444
// If we already have a TrackRemote for a given SSRC don't handle it again
445445
for t in local_transceivers {
446446
let receiver = t.receiver().await;
447447
let existing_tracks = receiver.tracks().await;
448-
log::info!("🔍 VALIDATION: Receiver has {} existing tracks", existing_tracks.len());
448+
// log::info!("🔍 VALIDATION: Receiver has {} existing tracks", existing_tracks.len());
449449
for track in existing_tracks {
450-
log::info!("🔍 VALIDATION: Existing track ssrc={}", track.ssrc());
450+
// log::info!("🔍 VALIDATION: Existing track ssrc={}", track.ssrc());
451451
for ssrc in &incoming_track.ssrcs {
452-
log::info!("🔍 VALIDATION: Comparing with incoming ssrc={}", ssrc);
452+
// log::info!("🔍 VALIDATION: Comparing with incoming ssrc={}", ssrc);
453453
if *ssrc == track.ssrc() {
454-
log::warn!("🔍 VALIDATION: ❌ FILTERING OUT track with ssrc={} (already exists)", ssrc);
454+
// log::warn!("🔍 VALIDATION: ❌ FILTERING OUT track with ssrc={} (already exists)", ssrc);
455455
filter_track_with_ssrc(&mut filtered_tracks, track.ssrc());
456456
}
457457
}
458458
}
459459
}
460460
}
461461
} else {
462-
log::info!("🔍 VALIDATION: Skipping filtering (renegotiation - receiver reset logic will handle duplicates)");
462+
// log::info!("🔍 VALIDATION: Skipping filtering (renegotiation - receiver reset logic will handle duplicates)");
463463
}
464464

465-
log::info!("🔍 VALIDATION: After filtering - filtered_tracks.len()={}", filtered_tracks.len());
466-
for (i, track) in filtered_tracks.iter().enumerate() {
467-
log::info!("🔍 VALIDATION: filtered_track[{}]: mid={}, ssrcs={:?}", i, track.mid, track.ssrcs);
468-
}
465+
// log::info!("🔍 VALIDATION: After filtering - filtered_tracks.len()={}", filtered_tracks.len());
466+
// for (i, track) in filtered_tracks.iter().enumerate() {
467+
// log::info!("🔍 VALIDATION: filtered_track[{}]: mid={}, ssrcs={:?}", i, track.mid, track.ssrcs);
468+
// }
469469

470470
let mut unhandled_tracks = vec![]; // filtered_tracks[:0]
471471
for incoming_track in filtered_tracks.iter() {
472-
log::info!("🔍 VALIDATION: Processing incoming_track mid={}", incoming_track.mid);
472+
// log::info!("🔍 VALIDATION: Processing incoming_track mid={}", incoming_track.mid);
473473
let mut track_handled = false;
474-
for (t_idx, t) in local_transceivers.iter().enumerate() {
475-
log::info!("🔍 VALIDATION: Checking transceiver[{}]", t_idx);
474+
for (_t_idx, t) in local_transceivers.iter().enumerate() {
475+
// log::info!("🔍 VALIDATION: Checking transceiver[{}]", _t_idx);
476476

477477
// Check 1: MID match
478478
let mid_match = t.mid().as_ref() == Some(&incoming_track.mid);
479-
log::info!("🔍 VALIDATION: MID check: t.mid={:?}, track.mid={}, MATCH={}",
480-
t.mid(), incoming_track.mid, mid_match);
479+
// log::info!("🔍 VALIDATION: MID check: t.mid={:?}, track.mid={}, MATCH={}",
480+
// t.mid(), incoming_track.mid, mid_match);
481481
if !mid_match {
482-
log::info!("🔍 VALIDATION: ❌ SKIPPED: MID mismatch");
482+
// log::info!("🔍 VALIDATION: ❌ SKIPPED: MID mismatch");
483483
continue;
484484
}
485485

486486
// Check 2: Kind match
487487
let kind_match = incoming_track.kind == t.kind();
488-
log::info!("🔍 VALIDATION: KIND check: track.kind={:?}, t.kind={:?}, MATCH={}",
489-
incoming_track.kind, t.kind(), kind_match);
488+
// log::info!("🔍 VALIDATION: KIND check: track.kind={:?}, t.kind={:?}, MATCH={}",
489+
// incoming_track.kind, t.kind(), kind_match);
490490

491491
// Check 3: Direction check
492492
let direction = t.direction();
493493
let direction_ok = direction == RTCRtpTransceiverDirection::Recvonly
494494
|| direction == RTCRtpTransceiverDirection::Sendrecv;
495-
log::info!("🔍 VALIDATION: DIRECTION check: t.direction={:?}, OK={}",
496-
direction, direction_ok);
495+
// log::info!("🔍 VALIDATION: DIRECTION check: t.direction={:?}, OK={}",
496+
// direction, direction_ok);
497497

498498
if !kind_match || !direction_ok {
499-
log::info!("🔍 VALIDATION: ❌ SKIPPED: kind or direction mismatch");
499+
// log::info!("🔍 VALIDATION: ❌ SKIPPED: kind or direction mismatch");
500500
continue;
501501
}
502502

@@ -506,22 +506,22 @@ impl PeerConnectionInternal {
506506
// these tracks as "NOT HANDLED", we recognize the receiver is already active and mark as handled.
507507
let receiver = t.receiver().await;
508508
let already_receiving = receiver.have_received().await;
509-
log::info!("🔍 VALIDATION: HAVE_RECEIVED check: {}", already_receiving);
509+
// log::info!("🔍 VALIDATION: HAVE_RECEIVED check: {}", already_receiving);
510510

511511
if already_receiving {
512512
if !is_renegotiation {
513-
log::info!("🔍 VALIDATION: ❌ SKIPPED: already receiving (initial negotiation)");
513+
// log::info!("🔍 VALIDATION: ❌ SKIPPED: already receiving (initial negotiation)");
514514
continue;
515515
} else {
516516
// During renegotiation, receiver already active - just mark as handled
517-
log::info!("🔍 VALIDATION: ✅ Renegotiation: receiver already active, marking as handled (no restart needed)");
517+
// log::info!("🔍 VALIDATION: ✅ Renegotiation: receiver already active, marking as handled (no restart needed)");
518518
track_handled = true;
519519
break;
520520
}
521521
}
522522

523523
// All checks passed - start receiver (only if not already receiving)
524-
log::info!("🔍 VALIDATION: ✅ ALL CHECKS PASSED - Starting receiver");
524+
// log::info!("🔍 VALIDATION: ✅ ALL CHECKS PASSED - Starting receiver");
525525
PeerConnectionInternal::start_receiver(
526526
self.setting_engine.get_receive_mtu(),
527527
incoming_track,
@@ -531,15 +531,15 @@ impl PeerConnectionInternal {
531531
)
532532
.await;
533533
track_handled = true;
534-
log::info!("🔍 VALIDATION: ✅ Receiver started successfully");
534+
// log::info!("🔍 VALIDATION: ✅ Receiver started successfully");
535535
}
536536

537537
if !track_handled {
538-
log::warn!("🔍 VALIDATION: ⚠️ Track NOT HANDLED: mid={}, kind={:?}, ssrcs={:?}",
539-
incoming_track.mid, incoming_track.kind, incoming_track.ssrcs);
538+
// log::warn!("🔍 VALIDATION: ⚠️ Track NOT HANDLED: mid={}, kind={:?}, ssrcs={:?}",
539+
// incoming_track.mid, incoming_track.kind, incoming_track.ssrcs);
540540
unhandled_tracks.push(incoming_track);
541541
} else {
542-
log::info!("🔍 VALIDATION: ✅ Track HANDLED: mid={}", incoming_track.mid);
542+
// log::info!("🔍 VALIDATION: ✅ Track HANDLED: mid={}", incoming_track.mid);
543543
}
544544
}
545545

0 commit comments

Comments
 (0)