Skip to content

Commit 470f43e

Browse files
committed
Silently fail on all login errors
1 parent afb9974 commit 470f43e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from setuptools import setup
22

33
setup(
4-
version="1.0.38",
4+
version="1.0.39",
55
install_requires=["slackclient", "celery"]
66
)

slack_app/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,6 @@ def refetch_user_slack_metadata(sender, user, request, **kwargs):
182182
for slack_user in user.slack_accounts.all():
183183
try:
184184
slack_user.update_slack_metadata()
185-
except SlackApiError:
186-
# for now fail silently
185+
except:
186+
# for now fail silently, since this is login related, we should catch all errors just to be sure
187187
pass

0 commit comments

Comments
 (0)