Skip to content

Commit 092c7ce

Browse files
authored
Fix test for win (#335)
1 parent 7a52c7e commit 092c7ce

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/scraper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ class Scraper {
137137
this.runActions('onResourceSaved', {resource});
138138
} catch (err) {
139139
logger.warn('failed to save resource ' + resource);
140-
return this.handleError(err, resource);
140+
await this.handleError(err, resource);
141141
}
142142
}
143143

test/unit/scraper-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe('Scraper', function () {
8383
var r = new Resource('http://example.com/a.png', 'a.png');
8484
r.setText('some text');
8585

86-
return s.saveResource(r).finally(function() {
86+
return s.saveResource(r).then(() => should(true).eql(false)).catch(function() {
8787
s.handleError.calledOnce.should.be.eql(true);
8888
s.handleError.calledWith(dummyError).should.be.eql(true);
8989
});
@@ -217,7 +217,7 @@ describe('Scraper', function () {
217217

218218
var r = new Resource('http://example.com/a.png');
219219

220-
return s.requestResource(r).finally(function() {
220+
return s.requestResource(r).then(() => should(true).eql(false)).catch(function() {
221221
s.handleError.calledOnce.should.be.eql(true);
222222
});
223223
});

0 commit comments

Comments
 (0)