Skip to content

Commit be96e91

Browse files
committed
Merge pull request #6 from s0ph1e/fix-extend
Fix _.extend usage issue, which override defaults data
2 parents 3c093cc + 4f4544c commit be96e91

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

lib/load.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ var Loader = function (data) {
1515
logger,
1616
makeRequest;
1717

18-
options = _.extend(defaults, data);
18+
options = _.extend({}, defaults, data);
1919

2020
// Set absolute path for directory
2121
options.directory = path.resolve(process.cwd(), options.directory || '');

lib/utils/request.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function getDefaultOptions() {
1414
}
1515

1616
function getCustomOptions(options) {
17-
return _.extend(defaultOptions, options);
17+
return _.extend({}, defaultOptions, options);
1818
}
1919

2020
function makeRequest(options, url) {

test/load-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ describe('Load', function(){
7777

7878
describe('#getDirectoryByExtension', function(){
7979
it('should return directory for extension specified in options', function(){
80-
var loader = new Loader(_.extend(defaultOptions, {
80+
var loader = new Loader(_.extend({}, defaultOptions, {
8181
subdirectories: [
8282
{
8383
directory: 'images',
@@ -102,7 +102,7 @@ describe('Load', function(){
102102
});
103103

104104
it('should return nothing if no directory for extension was set', function(){
105-
var loader = new Loader(_.extend(defaultOptions, {
105+
var loader = new Loader(_.extend({}, defaultOptions, {
106106
subdirectories: null
107107
}));
108108

@@ -117,7 +117,7 @@ describe('Load', function(){
117117
var directory = getTmpDirectoryName();
118118

119119
fs.mkdir(directory, function(){
120-
var loader = new Loader(_.extend(defaultOptions, {
120+
var loader = new Loader(_.extend({}, defaultOptions, {
121121
directory: directory
122122
}));
123123

@@ -140,7 +140,7 @@ describe('Load', function(){
140140
it('should return resolved promise if directory doesn\'t exist', function(){
141141
var directory = getTmpDirectoryName();
142142

143-
var loader = new Loader(_.extend(defaultOptions, {
143+
var loader = new Loader(_.extend({}, defaultOptions, {
144144
directory: directory
145145
}));
146146

0 commit comments

Comments
 (0)