Comments

Author: istarkov

packages/sdk-components-animation/src/scroll.tsx

@@ -19,9 +19,9 @@ const createSelector = (id: string) => `[${componentAttributeId}="${id}"] > *`;
 const cartesian = <A, B>(a: A[], b: B[]) =>
   a.flatMap((x) => b.map((y) => [x, y] as const));
 
-// See also WAAPI has bug https://issues.chromium.org/issues/40929569#comment9
-// so we are using calc even it it's not needed in some cases
 const getScrollRangeValue = ([name, value]: ScrollRangeValue) => {
+  // See also WAAPI has bug https://issues.chromium.org/issues/40929569#comment9
+  // so we are using calc even it it's not needed in some cases
   if (name === "start") {
     return `calc(0% + ${toValue(value)})`;
   }

packages/sdk-components-animation/src/shared/animation-types.tsx

@@ -84,6 +84,12 @@ type KeyframeEffectOptions = {
  * - "end" → `calc(100% - range)`
  */
 type ScrollNamedRange = "start" | "end";
+
+/**
+ * Scroll does not support https://drafts.csswg.org/scroll-animations/#named-ranges
+ * However, for simplicity and type unification with the view, we will use the names "start" and "end,"
+ * See ScrollNamedRange type for more information.
+ */
 export type ScrollRangeValue = [name: ScrollNamedRange, value: RangeUnitValue];
 
 type ScrollRangeOptions = {