Add comments etc

Author: istarkov

.github/workflows/chromatic.yml

@@ -20,12 +20,20 @@ jobs:
 
     runs-on: ubuntu-latest
 
+    environment:
+      name: development
+
     steps:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 2 # we need to fetch at least parent commit to satisfy Chromatic
           ref: ${{ github.event.pull_request.head.sha || github.sha }} # HEAD commit instead of merge commit
 
+      # Storybook with submodules
+      - uses: ./.github/actions/submodules-checkout
+        with:
+          submodules-ssh-key: ${{ secrets.PRIVATE_GITHUB_DEPLOY_TOKEN }}
+
       - uses: ./.github/actions/ci-setup
 
       - name: Chromatic

.github/workflows/cli-r2-static.yaml

@@ -30,6 +30,8 @@ jobs:
         with:
           ref: ${{ github.sha }} # HEAD commit instead of merge commit
 
+      # Do not checkout submodules, they are not needed for this workflow
+
       - uses: pnpm/action-setup@v4
 
       - uses: actions/setup-node@v4

.github/workflows/cli-r2.yaml

@@ -31,6 +31,11 @@ jobs:
         with:
           ref: ${{ github.sha }} # HEAD commit instead of merge commit
 
+      # We need submodules here as this is used for the cloudflare build
+      - uses: ./.github/actions/submodules-checkout
+        with:
+          submodules-ssh-key: ${{ secrets.PRIVATE_GITHUB_DEPLOY_TOKEN }}
+
       - uses: pnpm/action-setup@v4
 
       - uses: actions/setup-node@v4

.github/workflows/fixtures-test.yml

@@ -42,10 +42,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request.head.sha || github.sha }}
-
-      - run: |
-          echo "Secrets available: ${{ secrets.PRIVATE_GITHUB_DEPLOY_TOKEN != '' }}"
-
+      # Test that everything is working with submodules
       - uses: ./.github/actions/submodules-checkout
         with:
           submodules-ssh-key: ${{ secrets.PRIVATE_GITHUB_DEPLOY_TOKEN }}

.github/workflows/main.yml

@@ -18,8 +18,14 @@ jobs:
   checks:
     timeout-minutes: 20
 
+    strategy:
+      matrix:
+        environment:
+          - empty
+          - development
+
     environment:
-      name: development
+      name: ${{ matrix.environment }}
 
     env:
       DATABASE_URL: postgres://
@@ -32,6 +38,11 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.sha || github.sha }}
 
+      # Will not checkout submodules on empty environment, and will on development
+      - uses: ./.github/actions/submodules-checkout
+        with:
+          submodules-ssh-key: ${{ secrets.PRIVATE_GITHUB_DEPLOY_TOKEN }}
+
       - uses: ./.github/actions/ci-setup
 
       - uses: actions/cache@v4
@@ -44,23 +55,23 @@ jobs:
 
       - run: echo ===SHA USED=== ${{ github.event.pull_request.head.sha || github.sha }} # todo: remove after check whats happening on main
 
-      - run: pnpm prettier --cache --check "**/*.{js,md,ts,tsx}"
-
-      - run: pnpm lint --cache --cache-strategy=content --cache-location=node_modules/.cache/eslint/.eslint-cache
+      - run: |
+          pnpm prettier --cache --check "**/*.{js,md,ts,tsx}"
 
-      - run: pnpm -r test
-      - run: pnpm --filter=@webstudio-is/prisma-client build
-      - run: pnpm -r typecheck
+      - name: Lint
+        run: |
+          pnpm lint --cache --cache-strategy=content --cache-location=node_modules/.cache/eslint/.eslint-cache
 
-      - uses: ./.github/actions/submodules-checkout
-        with:
-          submodules-ssh-key: ${{ secrets.PRIVATE_GITHUB_DEPLOY_TOKEN }}
+      - name: Test
+        run: |
+          pnpm -r test
 
-      - run: |
-          pnpm -r --filter='sdk-components-animation' typecheck
+      - name: Typecheck
+        run: |
+          pnpm -r typecheck
 
   check-size:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04-arm
 
     environment:
       name: development