Skip to content

Commit 7f50fbe

Browse files
authored
fix: Rewrite overflow clip and hidden description (#5201)
## Description Rewrite overflow clip and hidden description and move it to css-data ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
1 parent 535d87d commit 7f50fbe

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

apps/builder/app/builder/features/style-panel/sections/size/size.tsx

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,26 +119,22 @@ export const Section = () => {
119119
items={[
120120
{
121121
child: <EyeOpenIcon />,
122-
description:
123-
"Content is fully visible and extends beyond the container if it exceeds its size.",
122+
description: propertyDescriptions["overflowX:visible"],
124123
value: "visible",
125124
},
126125
{
127126
child: <CropIcon />,
128-
description:
129-
"Content that exceeds the container's size is clipped without scrollbars.",
127+
description: propertyDescriptions["overflowX:clip"],
130128
value: "clip",
131129
},
132130
{
133131
child: <EyeClosedIcon />,
134-
description:
135-
"Content that exceeds the container's size is hidden without scrollbars.",
132+
description: propertyDescriptions["overflowX:hidden"],
136133
value: "hidden",
137134
},
138135
{
139136
child: <AutoScrollIcon />,
140-
description:
141-
"Scrollbars are added to the container only when necessary, based on the content size.",
137+
description: propertyDescriptions["overflowX:auto"],
142138
value: "auto",
143139
},
144140
]}

packages/css-data/src/__generated__/property-value-descriptions.ts

Lines changed: 12 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)