Skip to content

Commit 9486d26

Browse files
authored
fix: fix the tip for ellipsis (#5027)
## Description <img width="272" alt="image" src="https://github.com/user-attachments/assets/2cd2c2fb-b934-4fba-bf17-1553f5dbb316" /> This was misleading because we acually only need "text-wrap-mode" and "white space" in the UI is not actually white-space property ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
1 parent 10a4c70 commit 9486d26

File tree

1 file changed

+4
-4
lines changed
  • apps/builder/app/builder/features/style-panel/sections/typography

1 file changed

+4
-4
lines changed

apps/builder/app/builder/features/style-panel/sections/typography/typography.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -289,19 +289,19 @@ const TypographySectionAdvancedPopover = () => {
289289
>
290290
<Grid css={{ gridTemplateColumns: "5fr 5fr" }} gap={2}>
291291
<PropertyLabel
292-
label="White Space"
292+
label="White Space Collapse"
293293
description={propertyDescriptions.whiteSpaceCollapse}
294294
properties={["white-space-collapse"]}
295295
/>
296296
<SelectControl property="white-space-collapse" />
297297
<PropertyLabel
298-
label="Wrap Mode"
298+
label="Text Wrap Mode"
299299
description={propertyDescriptions.textWrapMode}
300300
properties={["text-wrap-mode"]}
301301
/>
302302
<SelectControl property="text-wrap-mode" />
303303
<PropertyLabel
304-
label="Wrap Style"
304+
label="Text Wrap Style"
305305
description={propertyDescriptions.textWrapStyle}
306306
properties={["text-wrap-style"]}
307307
/>
@@ -372,7 +372,7 @@ const TypographySectionAdvancedPopover = () => {
372372
{
373373
child: <TextTruncateIcon />,
374374
description:
375-
"The overflowing text is truncated with an ellipsis (...) to indicate that there is more content. To make the text-overflow: ellipsis property work, you need to set the following CSS properties: white-space: nowrap; overflow: hidden;",
375+
"The overflowing text is truncated with an ellipsis (...) to indicate that there is more content. To make the text-overflow: ellipsis property work, you need to set the following CSS properties: text-wrap-mode: nowrap; overflow: hidden;",
376376
value: "ellipsis",
377377
},
378378
]}

0 commit comments

Comments
 (0)