Skip to content

Commit 9fbce66

Browse files
committed
Split root and subdomain records
1 parent bc91b93 commit 9fbce66

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

apps/builder/app/builder/features/topbar/domains.tsx

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -306,15 +306,23 @@ const DomainItem = ({
306306
value: projectDomain.expectedTxtRecord,
307307
ttl: 300,
308308
};
309-
const dnsRecords: DnsRecord[] = [cnameRecord];
309+
let dnsRecords: Record<string, DnsRecord[]>;
310310
if (cname === "@") {
311-
dnsRecords.push(rootTxtRecord);
311+
dnsRecords = {
312+
domain: [cnameRecord, rootTxtRecord],
313+
};
312314
} else if (cname === "www") {
313315
// add both www and root cname to support root -> www redirect
314-
dnsRecords.push(rootTxtRecord, subdomainTxtRecord);
316+
dnsRecords = {
317+
domain: [rootTxtRecord],
318+
subDomain: [cnameRecord, subdomainTxtRecord],
319+
};
315320
} else {
316-
dnsRecords.push(subdomainTxtRecord);
321+
dnsRecords = {
322+
subDomain: [cnameRecord, subdomainTxtRecord],
323+
};
317324
}
325+
const dnsRecordsList = Object.values(dnsRecords).flat();
318326

319327
return (
320328
<CollapsibleDomainSection
@@ -448,7 +456,7 @@ const DomainItem = ({
448456
VALUE
449457
</Text>
450458

451-
{dnsRecords.map((record, index) => (
459+
{dnsRecordsList.map((record, index) => (
452460
<Fragment key={index}>
453461
<InputEllipsis readOnly value={record.type} />
454462
<InputEllipsis

apps/builder/app/builder/features/topbar/entri.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ export type DnsRecord = {
1414
ttl: number;
1515
};
1616

17+
export type DnsRecords = DnsRecord[] | Record<string, DnsRecord[]>;
18+
1719
type EntriCloseEvent = CustomEvent<entri.EntriCloseEventDetail>;
1820

1921
declare global {
@@ -37,7 +39,7 @@ const entriGlobalStyles = globalCss({
3739

3840
type EntriProps = {
3941
domain: string;
40-
dnsRecords: DnsRecord[];
42+
dnsRecords: DnsRecords;
4143
onClose: (detail: entri.EntriCloseEventDetail) => void;
4244
};
4345

@@ -105,7 +107,6 @@ export const Entri = ({ domain, dnsRecords, onClose }: EntriProps) => {
105107
css={{ width: "100%", flexShrink: 0 }}
106108
type="button"
107109
onClick={() => {
108-
// @todo temporary for testing
109110
if (hasProPlan) {
110111
showDialog();
111112
} else {

0 commit comments

Comments
 (0)