Skip to content

Commit b2f694f

Browse files
rename twitter:card size check for readability
1 parent 2cdad25 commit b2f694f

File tree

5 files changed

+30
-18
lines changed

5 files changed

+30
-18
lines changed

fixtures/ssg-netlify-by-project-id/pages/index/+Head.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
2525
format: "raw",
2626
})}`;
2727
}
28-
const isTwitterCardSizeExists = pageMeta.custom.some(
28+
const isTwitterCardSizeDefined = pageMeta.custom.some(
2929
(meta) => meta.property === "twitter:card"
3030
);
3131
return (
@@ -58,9 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
5858
{pageMeta.custom.map(({ property, content }) => (
5959
<meta key={property} property={property} content={content} />
6060
))}
61-
{isTwitterCardSizeExists === false && (
62-
<meta property="twitter:card" content="summary_large_image" />
63-
)}
61+
{(pageMeta.socialImageAssetName !== undefined ||
62+
pageMeta.socialImageUrl !== undefined) &&
63+
isTwitterCardSizeDefined === false && (
64+
<meta property="twitter:card" content="summary_large_image" />
65+
)}
6466

6567
{favIconAsset && (
6668
<link

fixtures/ssg/pages/another-page/+Head.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
2525
format: "raw",
2626
})}`;
2727
}
28-
const isTwitterCardSizeExists = pageMeta.custom.some(
28+
const isTwitterCardSizeDefined = pageMeta.custom.some(
2929
(meta) => meta.property === "twitter:card"
3030
);
3131
return (
@@ -58,9 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
5858
{pageMeta.custom.map(({ property, content }) => (
5959
<meta key={property} property={property} content={content} />
6060
))}
61-
{isTwitterCardSizeExists === false && (
62-
<meta property="twitter:card" content="summary_large_image" />
63-
)}
61+
{(pageMeta.socialImageAssetName !== undefined ||
62+
pageMeta.socialImageUrl !== undefined) &&
63+
isTwitterCardSizeDefined === false && (
64+
<meta property="twitter:card" content="summary_large_image" />
65+
)}
6466

6567
{favIconAsset && (
6668
<link

fixtures/ssg/pages/index/+Head.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
2525
format: "raw",
2626
})}`;
2727
}
28-
const isTwitterCardSizeExists = pageMeta.custom.some(
28+
const isTwitterCardSizeDefined = pageMeta.custom.some(
2929
(meta) => meta.property === "twitter:card"
3030
);
3131
return (
@@ -58,9 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
5858
{pageMeta.custom.map(({ property, content }) => (
5959
<meta key={property} property={property} content={content} />
6060
))}
61-
{isTwitterCardSizeExists === false && (
62-
<meta property="twitter:card" content="summary_large_image" />
63-
)}
61+
{(pageMeta.socialImageAssetName !== undefined ||
62+
pageMeta.socialImageUrl !== undefined) &&
63+
isTwitterCardSizeDefined === false && (
64+
<meta property="twitter:card" content="summary_large_image" />
65+
)}
6466

6567
{favIconAsset && (
6668
<link

packages/cli/templates/ssg/app/route-templates/html/+Head.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
2525
format: "raw",
2626
})}`;
2727
}
28-
const isTwitterCardSizeExists = pageMeta.custom.some(
28+
const isTwitterCardSizeDefined = pageMeta.custom.some(
2929
(meta) => meta.property === "twitter:card"
3030
);
3131
return (
@@ -58,9 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
5858
{pageMeta.custom.map(({ property, content }) => (
5959
<meta key={property} property={property} content={content} />
6060
))}
61-
{isTwitterCardSizeExists === false && (
62-
<meta property="twitter:card" content="summary_large_image" />
63-
)}
61+
{(pageMeta.socialImageAssetName !== undefined ||
62+
pageMeta.socialImageUrl !== undefined) &&
63+
isTwitterCardSizeDefined === false && (
64+
<meta property="twitter:card" content="summary_large_image" />
65+
)}
6466

6567
{favIconAsset && (
6668
<link

packages/react-sdk/src/page-settings-meta.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,14 @@ export const PageSettingsMeta = ({
137137

138138
metas.push(...pageMeta.custom);
139139

140-
const isTwitterCardSizeExists = pageMeta.custom.some(
140+
const isTwitterCardSizeDefined = pageMeta.custom.some(
141141
(meta) => meta.property === "twitter:card"
142142
);
143-
if (isTwitterCardSizeExists === false) {
143+
if (
144+
(pageMeta.socialImageAssetName !== undefined ||
145+
pageMeta.socialImageUrl !== undefined) &&
146+
isTwitterCardSizeDefined === false
147+
) {
144148
metas.push({ property: "twitter:card", content: "summary_large_image" });
145149
}
146150

0 commit comments

Comments
 (0)