Skip to content

Commit ba347fd

Browse files
kofTrySound
authored andcommitted
fix: Improve made with webstudio badge tooltip (#5266)
Trying to explain that user can change the styles and position and everything about that badge. ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
1 parent 9008c41 commit ba347fd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

apps/builder/app/builder/features/topbar/publish.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ const $usedProFeatures = computed(
273273
const badgeFeature = 'No "Built with Webstudio" badge';
274274
// Badge should be rendered on free sites on every page.
275275
features.set(badgeFeature, {
276-
info: "Adding the badge to your homepage helps us offer a free version of the service. Please open the Components panel by clicking the “+” icon on the left, and add the “Built with Webstudio” component to your page. Feel free to adjust the badge’s styles to match your design.",
276+
info: "Adding the badge to your homepage helps us offer a free version of the service. Please open the Components panel by clicking the “+” icon on the left, and add the “Built with Webstudio” component to your page. Feel free to adjust the badge's style to match your design - after all, it's just a link, and you can place it wherever you like.",
277277
});
278278
// We want to check the badge only on the home page
279279
const homePageInstanceIds = findTreeInstanceIds(
@@ -288,7 +288,8 @@ const $usedProFeatures = computed(
288288
for (const prop of props ?? []) {
289289
if (
290290
prop.name === "href" &&
291-
prop.value === "https://webstudio.is/?via=badge"
291+
typeof prop.value === "string" &&
292+
prop.value.includes("https://webstudio.is")
292293
) {
293294
features.delete(badgeFeature);
294295
}

0 commit comments

Comments
 (0)