Skip to content

Commit c14238e

Browse files
authored
experimental: override some tags with components (#5210)
Ref #3632 Remix client routing should still work even if we go full html. Here added tag overrides to component generator so sdk could pass component replacements for some tags like - body -> Body - a -> Link - form -> RemixForm See example here https://github.com/webstudio-is/webstudio/pull/5210/files#diff-f2df0aea6543a33e57d770ff1791da886ab3dfd6dec37da4a41a611b9b13a19aR6
1 parent e35de86 commit c14238e

35 files changed

+262
-214
lines changed

fixtures/webstudio-features/.webstudio/data.json

Lines changed: 56 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
{
22
"build": {
3-
"id": "f0dfc2e7-240a-4542-ad28-a4cb68b2d9db",
3+
"id": "043bda3f-0d77-4656-aa9c-652c1a1f272e",
44
"projectId": "cddc1d44-af37-4cb6-a430-d300cf6f932d",
5-
"version": 583,
6-
"createdAt": "2025-04-14T09:45:34.257+00:00",
7-
"updatedAt": "2025-04-14T09:45:34.257+00:00",
5+
"version": 593,
6+
"createdAt": "2025-05-15T22:04:05.511+00:00",
7+
"updatedAt": "2025-05-15T22:04:05.511+00:00",
88
"pages": {
99
"meta": {
1010
"siteName": "KittyGuardedZone",
@@ -2165,6 +2165,18 @@
21652165
"value": "center"
21662166
}
21672167
}
2168+
],
2169+
[
2170+
"U6kV-2LTnN9kR4jWfLb1c:UoTkWyaFuTYJihS3MFYK5:display:",
2171+
{
2172+
"breakpointId": "UoTkWyaFuTYJihS3MFYK5",
2173+
"styleSourceId": "U6kV-2LTnN9kR4jWfLb1c",
2174+
"property": "display",
2175+
"value": {
2176+
"type": "keyword",
2177+
"value": "block"
2178+
}
2179+
}
21682180
]
21692181
],
21702182
"styleSources": [
@@ -2482,6 +2494,13 @@
24822494
"type": "local",
24832495
"id": "hEVSzkOEBn_3dNyo65PAM"
24842496
}
2497+
],
2498+
[
2499+
"U6kV-2LTnN9kR4jWfLb1c",
2500+
{
2501+
"type": "local",
2502+
"id": "U6kV-2LTnN9kR4jWfLb1c"
2503+
}
24852504
]
24862505
],
24872506
"styleSourceSelections": [
@@ -2799,6 +2818,13 @@
27992818
"instanceId": "g__o13UKOkD0KImnp-sWp",
28002819
"values": ["hEVSzkOEBn_3dNyo65PAM"]
28012820
}
2821+
],
2822+
[
2823+
"Ol5bklKKxyJaS7Q3jcCfD",
2824+
{
2825+
"instanceId": "Ol5bklKKxyJaS7Q3jcCfD",
2826+
"values": ["U6kV-2LTnN9kR4jWfLb1c"]
2827+
}
28022828
]
28032829
],
28042830
"props": [
@@ -2812,16 +2838,6 @@
28122838
"value": "cd939c56-bcdd-4e64-bd9c-567a9bccd3da"
28132839
}
28142840
],
2815-
[
2816-
"SYK4hpLQ9tHnESKDtPvI9",
2817-
{
2818-
"id": "SYK4hpLQ9tHnESKDtPvI9",
2819-
"instanceId": "l9AI_pShC-BH4ibxK6kNT",
2820-
"name": "href",
2821-
"type": "string",
2822-
"value": "https://github.com/"
2823-
}
2824-
],
28252841
[
28262842
"_x-dxwbTQ-XBLRuYQE9Pm",
28272843
{
@@ -4111,6 +4127,16 @@
41114127
"type": "boolean",
41124128
"value": true
41134129
}
4130+
],
4131+
[
4132+
"qG9NyGQuq0KVR0zvf76Er",
4133+
{
4134+
"id": "qG9NyGQuq0KVR0zvf76Er",
4135+
"instanceId": "Ol5bklKKxyJaS7Q3jcCfD",
4136+
"name": "href",
4137+
"type": "string",
4138+
"value": "https://github.com/"
4139+
}
41144140
]
41154141
],
41164142
"dataSources": [
@@ -4432,7 +4458,7 @@
44324458
},
44334459
{
44344460
"type": "id",
4435-
"value": "l9AI_pShC-BH4ibxK6kNT"
4461+
"value": "Ol5bklKKxyJaS7Q3jcCfD"
44364462
},
44374463
{
44384464
"type": "id",
@@ -4508,20 +4534,6 @@
45084534
"children": []
45094535
}
45104536
],
4511-
[
4512-
"l9AI_pShC-BH4ibxK6kNT",
4513-
{
4514-
"type": "instance",
4515-
"id": "l9AI_pShC-BH4ibxK6kNT",
4516-
"component": "Link",
4517-
"children": [
4518-
{
4519-
"type": "text",
4520-
"value": "Click here to adore more kittens"
4521-
}
4522-
]
4523-
}
4524-
],
45254537
[
45264538
"uKWGyE9JY3cPwY-xI9vk6",
45274539
{
@@ -6728,6 +6740,21 @@
67286740
}
67296741
]
67306742
}
6743+
],
6744+
[
6745+
"Ol5bklKKxyJaS7Q3jcCfD",
6746+
{
6747+
"type": "instance",
6748+
"id": "Ol5bklKKxyJaS7Q3jcCfD",
6749+
"component": "ws:element",
6750+
"tag": "a",
6751+
"children": [
6752+
{
6753+
"type": "text",
6754+
"value": "Click here to adore more kittens"
6755+
}
6756+
]
6757+
}
67316758
]
67326759
],
67336760
"deployment": {

fixtures/webstudio-features/app/__generated__/$resources.sitemap.xml.ts

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[_route_with_symbols_]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[animations]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[class-names]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[content-block]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[duration]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[expressions]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[form]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

fixtures/webstudio-features/app/__generated__/[head-tag]._index.tsx

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)