-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
As a builder, I want to let a customer edit text and images without giving them the full power of the builder.
Here is how it can work:
Step 1. Add Content Edit mode to the panel (similar to Preview button at the top panel).
- Remove Style panel
- At left show Pages, Navigator, Assets
- Disable Binding editing.
- Disable Canvas drag.
- Disable Tree drag.
- In the properties panel, show only Link and Img tag default properties (but not ID or Class), do not allow add new properties.
- Do not show/allow bindings editing (text editing in binded instances too).
- Disable copy/paste
- Add EditContent button
- Enable text editing functionality.
- Probably allow text editing in a single click instead of double click in Edit Mode.
- Make edit styles (i.e. show "text" cursor on editable text)
Roll out without feature flag or public announcement.
Step 2. Add "content editor" Share link.
- Do some system rest API checks to not allow patching styles, props (only img and link are allowed)
- Free users can't share Content Edit Link
- All shared links from Free users must not have Content Edit mode
Roll out without feature flag or public announcement.
Step 2.5 Add combo for modes
- - Switch preview, design, content using combo like switch
- - Padding right at menu is not ok (feat: Reorder items in the build menuย #4484)
- - Order Design/Build/Preview (feat: Reorder items in the build menuย #4484)
- - Rename modes (Visible Text initially)
- - Do not reset to preview automatically (feat: Reorder items in the build menuย #4484)
- - Button zone (feat: Plus button hover polygon and menu iconsย #4487)
Step 3. Allow content Editors to upload and modify images
- Roll out without feature flag or public announcement.
Step 4. Introduce the EditableBlock component.
EditableBlock
- Templates (Designers can add components within a controlled template area.)
- Header
- Article
- Anything
- Header Edited By user
- Article Edited By user
- Article Edited By user
-
The content editor can copy components from the
Templatesarea directly into theEditableBlock, making them immediate children of theEditableBlock(UI inspired by Notion or potentially with a โ+โ button at the bottom of each block, open for discussion). -
Component Reordering: Users can reorder components vertically within the EditableBlock. (Note: Dragging on the main canvas is not yet supported. Lack of main canvas dragging is acceptable in the editor at this stage.) (Done at feat: Allow delete/reorder Content Block children in Content modeย #4483)
-
Allow delete block children (_done at feat: Allow delete/reorder Content Block children in Content modeย #4483)
-
Alt click to insert before (done at feat: Add alt click (insert before) to editable blockย #4479 )
-
Meta Icons in Menu (now BoxIcon is hardcoded) (feat: Plus button hover polygon and menu iconsย #4487)
-
Allow delete descendants of editable block children???? -
Make text more readable about deletion - toasts texts.
-
Change Icon for editable template https://www.figma.com/design/sfCE7iLS0k25qCxiifQNLE/%F0%9F%93%9A-Webstudio-Library?node-id=10054-1724&t=fUa78q94ZNOOlm8J-4 (feat: Change Block/Template iconย #4486)
-
- Editable Block => Content Block chore: Rename editable block componentย #4489
-
- Plain tree, show only Content Blocks @TrySound
-
- Alt converts
+Icon toDeleteicon. Inside menu we are writingALT. Menu minWidth is not enough, max too. feat: Transform Plus button to Minus in case of Alt button is pressedย #4490 -
- Content Block without Templates is just wrapper which makes internal elements visible in navigation panel feat: Transform Plus button to Minus in case of Alt button is pressedย #4490
-
- Fix bug that after adding element it's not hoverable for like 500ms feat: Transform Plus button to Minus in case of Alt button is pressedย #4490
-
- Fix bug that cursor TEXT is not applied to newly created elements in editable block feat: Transform Plus button to Minus in case of Alt button is pressedย #4490
-
- Fix bug that something strange is happening with collapsed style when adding first template fix: Collapsed state was incorrectly calculated in some cases. ย #4492
-
- Publish not working @istarkov feat: Content Block publish component generatorย #4495
-
- Menu height 24px @kof
-
- Default texts https://discord.com/channels/955905230107738152/1115982879651016814/1312810680834850907 feat: Add initial text to the Content Blockย #4498
-
- When clicking "Content Block" in the navigator, nothing is scrolled into view. Only when clicking on the children. It's an existing bug with scroll to display:contents fix: Scroll to display contents elements.ย #4519
-
- Content mode can publish. With can Publish checkbox feat: Add "can publish" to content editorsย #4530
-
- When a mode like "Content" is selected in share links, it's odd that clone and copy are checked and blue. always was for every regime fix: When a mode like "Content" is selected in share links, it's odd that clone and copy are checked and blueย #4526
-
- When inserting a template instance, it should be selected automatically. Currently, the previously selected instance stays selected. fix: Scroll to display contents elements.ย #4519
-
- Disable project settings edit feat: Allow page clone in Content Edit modeย #4531
-
- Allow page clone feat: Allow page clone in Content Edit modeย #4531
-
- Change menu button on modern variant feat: Add new button mode switch buttonย #4532
-
- Do not show
Editable block you can editin preview fix: Do not show empty content blocks in preview modeย #4533 -
- Toggle always between preview and current mode feat: Add new button mode switch buttonย #4532
Roll out WITH public announcement.
After Step 5. Explore drag-and-drop functionality on the main canvas.
- This step requires careful planning to avoid complexity that may lead to extensive development cycles.
- Show rich text subcomponents settings & style panel during text edit i.e. link inside rich text
Steps | Issues from @johnsicili
- (just noting) Seems odd to have the right panel when the majority of the time it just consumes valuable space. I don't have ideas right now. Maybe in the future we'll add link and image editing in canvas and can do without right panel for clients
- - (known issue) Links are hard to edit when adding them inline
- - I don't love image dimension fields exposed because I often reduce the dimensions to better optimize. But if they replace the image then I guess it doesn't matter.
- - They can edit text content on XML. IDK if this is a problem.
- -
Add info about publishing permissions to tooltip (e.g., Can publish with this permission) - -
Disable Show toggle
Steps from @kof
- - Decide Content or Content Edit in share dialog?
Metadata
Metadata
Labels
Type
Projects
Status
