Skip to content

experimental: generate root styles for published sites #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2024
Merged

experimental: generate root styles for published sites #4177

merged 5 commits into from
Oct 1, 2024

Conversation

@TrySound
Copy link
Member

@TrySound TrySound commented Sep 28, 2024 •
edited
Loading

Ref #3399

  • render layout hack (display: grid; min-height: 100%) as root preset styles
  • generate root user styles on published sites
  • moved typography preset from body to the root
  • bumped a couple of deps
Screenshot 2024-09-28 at 23 25 08

@TrySound TrySound requested review from johnsicili and kof September 28, 2024 22:03
johnsicili
johnsicili requested changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preset root styles (at least grid and height) don't show in the Style Panel until clicking on the body/possibly any instance that has styles.

  1. Refresh page
  2. Check root styles see no grid
  3. Click body
  4. Click root see grid
grid.mp4

@TrySound
experimental: generate root styles for published sites
e855198 
Ref #3399

- render layout hack as root preset styles
- generate root user styles on published sites
- bumped a couple of deps
@TrySound
Move typography reset to html
2aa5021
@TrySound
Fix test
6ed38ef
@TrySound
Update fixtures
7227521
@TrySound
Prevent atomizing :root rules
ef4950b
@TrySound TrySound force-pushed the generate-root-styles.staging branch from 43e75ac to ef4950b Compare September 29, 2024 15:06
@TrySound
Copy link
Member Author

TrySound commented Sep 29, 2024

@johnsicili was a separate bug Ivan fixed, rebased. Now should work as expected.

@johnsicili johnsicili self-requested a review September 29, 2024 15:21
@TrySound TrySound merged commit c05ccdd into main Oct 1, 2024
27 checks passed
@TrySound TrySound deleted the generate-root-styles.staging branch October 1, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@istarkov istarkov istarkov approved these changes

@johnsicili johnsicili johnsicili approved these changes

@kof kof Awaiting requested review from kof

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrySound @istarkov @johnsicili