From 3db5f7b5463931a55ed1126229ef3b9e25998a05 Mon Sep 17 00:00:00 2001 From: victor Date: Tue, 18 Feb 2025 20:40:50 +0530 Subject: [PATCH 1/2] fix: remove trim from onchange event and trim the value onBlur (#4729) --- .../builder/features/settings-panel/settings-section.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/apps/builder/app/builder/features/settings-panel/settings-section.tsx b/apps/builder/app/builder/features/settings-panel/settings-section.tsx index 71c90ae45282..a597332d1f9a 100644 --- a/apps/builder/app/builder/features/settings-panel/settings-section.tsx +++ b/apps/builder/app/builder/features/settings-panel/settings-section.tsx @@ -50,8 +50,11 @@ export const SettingsSection = () => { key={selectedInstance.id} placeholder={placeholder} value={localValue.value} - onChange={(event) => localValue.set(event.target.value.trim())} - onBlur={localValue.save} + onChange={(event) => localValue.set(event.target.value)} + onBlur={(event) => { + localValue.set((event.target as HTMLInputElement).value.trim()); + localValue.save; + }} /> From 8785b791171b0ecbcc44a25af780c4e742a694e7 Mon Sep 17 00:00:00 2001 From: victor Date: Thu, 20 Feb 2025 16:43:43 +0530 Subject: [PATCH 2/2] fix: made some changes to fix in issue (#4729) --- .../builder/features/settings-panel/settings-section.tsx | 9 +++++---- .../app/builder/features/settings-panel/shared.tsx | 7 +++++++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/apps/builder/app/builder/features/settings-panel/settings-section.tsx b/apps/builder/app/builder/features/settings-panel/settings-section.tsx index a597332d1f9a..0dad0bea88f1 100644 --- a/apps/builder/app/builder/features/settings-panel/settings-section.tsx +++ b/apps/builder/app/builder/features/settings-panel/settings-section.tsx @@ -51,10 +51,11 @@ export const SettingsSection = () => { placeholder={placeholder} value={localValue.value} onChange={(event) => localValue.set(event.target.value)} - onBlur={(event) => { - localValue.set((event.target as HTMLInputElement).value.trim()); - localValue.save; - }} + onBlur={(event) => + localValue.finalSave( + (event.target as HTMLInputElement).value.trim() + ) + } /> diff --git a/apps/builder/app/builder/features/settings-panel/shared.tsx b/apps/builder/app/builder/features/settings-panel/shared.tsx index e74bcad9d2bd..d277b0f48ea1 100644 --- a/apps/builder/app/builder/features/settings-panel/shared.tsx +++ b/apps/builder/app/builder/features/settings-panel/shared.tsx @@ -175,6 +175,12 @@ export const useLocalValue = ( } }; + const finalSave = (value: Type) => { + localValueRef.current = value; + setRefresh((refresh) => refresh + 1); + save(); + }; + const saveDebounced = useDebouncedCallback(save, 500); const setLocalValue = (value: Type) => { @@ -224,6 +230,7 @@ export const useLocalValue = ( * Should be called on onBlur or similar event */ save, + finalSave, }; };