Skip to content

fix: optimize saving global variables #4936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

fix: optimize saving global variables #4936

merged 1 commit into from
Mar 1, 2025
+18 −12

Conversation

@TrySound
Copy link
Member

@TrySound TrySound commented Feb 28, 2025

Reduced amount iterations over all instances
to optimize rebinding variables on save.

@TrySound
fix: optimize saving global variables
2ab0217 
Reduces amount iteractions over all instances
to optimize rebinding variables on save.
@TrySound TrySound requested review from johnsicili and kof February 28, 2025 18:43
kof
kof approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested

@TrySound TrySound merged commit 8891748 into main Mar 1, 2025
17 checks passed
@TrySound TrySound deleted the optimize-vars branch March 1, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kof kof kof approved these changes

@johnsicili johnsicili johnsicili approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TrySound @kof @johnsicili