From 4ff71e1079ed5ecebb1b9089ed779978925246b9 Mon Sep 17 00:00:00 2001
From: Bogdan Chadkin <opensource@trysound.io>
Date: Sun, 3 Aug 2025 18:10:45 +0200
Subject: [PATCH] fix: accept any string in <iframe> name attribute

Fixes https://discord.com/channels/955905230107738152/1400906922235920445/1400906922235920445

The spec does not clearly indicate possible values and in case of iframe
and object name attribute accepts any string.
---
 packages/html-data/bin/attributes.ts                  |  2 +-
 .../src/__generated__/attributes-jsx-test.tsx         | 11 ++---------
 packages/html-data/src/__generated__/attributes.ts    |  9 ++++-----
 3 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/packages/html-data/bin/attributes.ts b/packages/html-data/bin/attributes.ts
index 5a7a3edfb940..fb3072e46250 100644
--- a/packages/html-data/bin/attributes.ts
+++ b/packages/html-data/bin/attributes.ts
@@ -163,7 +163,7 @@ for (const row of rows) {
     .split(/\s*;\s*/)
     .filter((item) => item.startsWith('"') && item.endsWith('"'))
     .map((item) => item.slice(1, -1));
-  if (value.includes("valid navigable target name or keyword")) {
+  if (attribute === "target" || attribute === "formtarget") {
     possibleOptions = ["_blank", "_self", "_parent", "_top"];
   }
   if (value.includes("input type keyword")) {
diff --git a/packages/html-data/src/__generated__/attributes-jsx-test.tsx b/packages/html-data/src/__generated__/attributes-jsx-test.tsx
index 0f26054bfb40..d9df93eb8c07 100644
--- a/packages/html-data/src/__generated__/attributes-jsx-test.tsx
+++ b/packages/html-data/src/__generated__/attributes-jsx-test.tsx
@@ -2075,7 +2075,7 @@ const Page = () => {
         allowFullScreen={true}
         height={0}
         loading={"lazy"}
-        name={"_blank"}
+        name={""}
         referrerPolicy={""}
         sandbox={""}
         src={""}
@@ -2538,14 +2538,7 @@ const Page = () => {
         xmlLang={""}
         xmlSpace={""}
       />
-      <object
-        data={""}
-        form={""}
-        height={0}
-        name={"_blank"}
-        type={""}
-        width={0}
-      />
+      <object data={""} form={""} height={0} name={""} type={""} width={0} />
       <ol reversed={true} start={0} type={"1"} />
       <optgroup disabled={true} label={""} />
       <option disabled={true} label={""} value={""} />
diff --git a/packages/html-data/src/__generated__/attributes.ts b/packages/html-data/src/__generated__/attributes.ts
index ac959a423b1d..744ea347aa19 100644
--- a/packages/html-data/src/__generated__/attributes.ts
+++ b/packages/html-data/src/__generated__/attributes.ts
@@ -973,11 +973,10 @@ const attribute_y2_gxmray: Attribute = {
   type: "string",
 };
 
-const attribute_name_1dbhjn1: Attribute = {
+const attribute_name_14zrnwf: Attribute = {
   name: "name",
   description: "Name of content navigable",
-  type: "select",
-  options: ["_blank", "_self", "_parent", "_top"],
+  type: "string",
 };
 
 const attribute_type_1swzf44: Attribute = {
@@ -3726,7 +3725,7 @@ export const attributesByTag: Record<string, undefined | Attribute[]> = {
     },
     attribute_height_10887hn,
     attribute_loading_yzzdw4,
-    attribute_name_1dbhjn1,
+    attribute_name_14zrnwf,
     attribute_referrerpolicy_tpprqt,
     {
       name: "sandbox",
@@ -4365,7 +4364,7 @@ export const attributesByTag: Record<string, undefined | Attribute[]> = {
     },
     attribute_form_1v3e5z4,
     attribute_height_10887hn,
-    attribute_name_1dbhjn1,
+    attribute_name_14zrnwf,
     attribute_type_1swzf44,
     attribute_width_d9q964,
   ],