Error running examples/hello_world example

[nomadme]

The example deno-webui/examples/hello_world is failing to run with following code right out of the fresh clone of the repo.

*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'NSWindow should only be instantiated on the main thread!'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000018d22ae80 __exceptionPreprocess + 176
	1   libobjc.A.dylib                     0x000000018cd12cd8 objc_exception_throw + 88
	2   CoreFoundation                      0x000000018d24f534 _CFBundleGetValueForInfoKey + 0
	3   AppKit                              0x0000000190d40460 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 260
	4   AppKit                              0x0000000190d40350 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 48
	5   libwebui-2.dylib                    0x000000013076f250 _webui_macos_wv_new + 192
	6   libwebui-2.dylib                    0x000000013075463c _webui_show_window + 1680
	7   libffi.dylib                        0x000000019eea3050 ffi_call_SYSV + 80
	8   libffi.dylib                        0x000000019eeabb04 ffi_call_int + 1208
	9   deno                                0x00000001016efcb8 _ZN8deno_ffi4call8ffi_call17hc5aed27f54aea7b0E + 864
	10  deno                                0x00000001016ff1f0 _ZN5tokio7runtime4task3raw4poll17h9e1fa0c9d267d1f7E + 368
	11  deno                                0x00000001023e1fe0 _ZN3std3sys9backtrace28__rust_begin_short_backtrace17hbcaa8672f8eb464cE + 384
	12  deno                                0x00000001023eada0 _ZN4core3ops8function6FnOnce40call_once$u7b$$u7b$vtable.shim$u7d$$u7d$17he20da08ab12b0168E + 120
	13  deno                                0x00000001022e6a18 _ZN3std3sys3pal4unix6thread6Thread3new12thread_start17hafa247f57517f341E + 52
	14  libsystem_pthread.dylib             0x000000018d0d02e4 _pthread_start + 136
	15  libsystem_pthread.dylib             0x000000018d0cb0fc thread_start + 8
)
libc++abi: terminating due to uncaught exception of type NSException
[1]    19141 abort      deno run --allow-read --allow-write --allow-net --allow-env --allow-ffi 

I'm on:

deno 2.2.9
46b73b4 (HEAD -> main, tag: 2.5.8, origin/main, origin/HEAD) Merge pull request #90 from sigmaSd/p2

[sigmaSd]

Can you try setting nonblocking to false here https://github.com/webui-dev/deno-webui/blob/main/src/lib.ts#L22 and try again

[AlbertShown]

I think this is an internal webui bug, we will try to fix it later this week as we are in vacation right now.

[sigmaSd]

@hassandraga is this commit 731dd91 meant for this issue ?

In that case I prefer if we make it still non blocking on Linux because it works correctly there, we can just make it conditional based on Deno.build.os

[hassandraga]

@sigmaSd, Yes, I was actually thinking of that, however, I did not fully fix the issue yet, the commit is a hot-fix only, therefore the actual release will still use non-blocking.

[sigmaSd]

@nomadme can you confirm this issue is fixed in version 2.5.9 ?