Improved DB type mapping

Author: Rike-cz

classes/drivers/Mysql.php

@@ -1,7 +1,6 @@
 <?php namespace Webula\SmallBackup\Classes\Drivers;
 
 use Illuminate\Database\Connection;
-use Webula\SmallBackup\Models\Settings;
 
 class Mysql implements Contracts\BackupStream
 {
@@ -25,13 +24,7 @@ public function __construct(Connection $connection, array $excludedTables = [])
         $this->connection = $connection;
         $this->excludedTables = $excludedTables;
 
-        /**
-         * Override missing json type if needed
-         */
-        if( Settings::get('doctrine_maping', null) )
-        {
-            \DB::getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'text');
-        }
+        $this->syncPlatformMapping();
     }
 
     /**
@@ -288,6 +281,23 @@ protected function getCharset(): string
     }
 
 
+    /**
+     * Sync doctrine platform mapping
+     *
+     * @return void
+     */
+    protected function syncPlatformMapping(): void
+    {
+        $platform = $this->connection->getDoctrineSchemaManager()->getDatabasePlatform();
+        if (!$platform->hasDoctrineTypeMappingFor('json')) {
+            $platform->registerDoctrineTypeMapping('json', \Doctrine\DBAL\Types\Type::TEXT);
+        }
+        if (!$platform->hasDoctrineTypeMappingFor('enum')) {
+            $platform->registerDoctrineTypeMapping('enum', \Doctrine\DBAL\Types\Type::STRING);
+        }
+    }
+
+
     /**
      * Wrap table/database name
      *

lang/cs/lang.php

@@ -36,7 +36,6 @@
             'database' => 'Databáze',
             'theme' => 'Šablona',
             'backups' => 'Zálohy',
-            'settings' => 'Nastavení',
         ],
 
         'backup_folder' => 'Adresář pro umístění záloh',
@@ -56,8 +55,5 @@
         'section_db' => 'Databáze',
         'section_theme' => 'Téma vzhledu',
         'section_listing' => 'Výpis záloh',
-
-        'doctrine_maping' => 'Přepsat mapování typů sloupců DB',
-        'doctrine_maping_comment' => 'Pokud při zálohování databáze dostáváte chybu s nepodporovaným typem, povolením této volby budou přemapovány. Podporovaná mapování jsou: [json => text].',
     ],
 ];

lang/en/lang.php

@@ -36,7 +36,6 @@
             'database' => 'Database',
             'theme' => 'Theme',
             'backups' => 'Backups',
-            'settings' => 'Settings',
         ],
 
         'backup_folder' => 'Backup folder',
@@ -56,8 +55,5 @@
         'section_db' => 'Database',
         'section_theme' => 'Theme',
         'section_listing' => 'List of backups',
-
-        'doctrine_maping' => 'Override DB columns type mapping',
-        'doctrine_maping_comment' => 'If you receive DB backup error with unsupported type message, enable this to override type mapping. Supported mappings are: [json => text].',
     ],
 ];

models/settings/fields.yaml

@@ -61,10 +61,3 @@ tabs:
             type: partial
             path: $/webula/smallbackup/controllers/settings/_listing-theme.htm
             tab: webula.smallbackup::lang.settings.tabs.theme
-
-        doctrine_maping:
-            label: webula.smallbackup::lang.settings.doctrine_maping
-            comment: webula.smallbackup::lang.settings.doctrine_maping_comment
-            type: checkbox
-            span: left
-            tab: webula.smallbackup::lang.settings.tabs.settings

updates/version.yaml

@@ -1,4 +1,4 @@
 1.0.1: First version of SmallBackup
 1.0.2: Fixed flash message content
-1.1.0: 
-  - Added option to override DB type mapping
+1.1.0:
+  - Fixed missing DB type mapping