feat: unload all instances when unload is called (#120)

Author: eliassjogreen

.github/workflows/build.yml

@@ -42,7 +42,11 @@ jobs:
       - name: Upload Artifacts
         uses: actions/upload-artifact@v3
         with:
-          path: build/
+          name: build
+          path: |
+            build/*.dll
+            build/*.dylib
+            build/*.so
 
 #      - name: Release Plugin
 #        uses: softprops/action-gh-release@master

src/ffi.ts

@@ -1,4 +1,5 @@
 import { CachePolicy, download, join, prepare } from "../deps.ts";
+import { Webview } from "./webview.ts";
 
 const version = "0.7.2";
 const policy = Deno.env.get("PLUGIN_URL") === undefined
@@ -22,6 +23,12 @@ async function checkForWebView2Loader(): Promise<boolean> {
 // make sure we don't preload twice
 let preloaded = false;
 
+/**
+ * All active webview instances. This is internally used for automatically
+ * destroying all instances once {@link unload} is called.
+ */
+export const instances: Webview[] = [];
+
 /**
  * Loads the `./WebView2Loader.dll` for running on Windows. Removes old version
  * if it already existed, and only runs once. Should be run on the main thread
@@ -55,6 +62,9 @@ export async function preload() {
  * otherwise, you may have to call this manually.
  */
 export function unload() {
+  for (const instance of instances) {
+    instance.destroy();
+  }
   lib.close();
   if (Deno.build.os === "windows") {
     Deno.removeSync("./WebView2Loader.dll");

src/webview.ts

@@ -1,4 +1,4 @@
-import sys from "./ffi.ts";
+import sys, { instances } from "./ffi.ts";
 
 const encoder = new TextEncoder();
 const encode = (value: string) => encoder.encode(value + "\0");
@@ -174,6 +174,9 @@ export class Webview {
     if (size !== undefined) {
       this.size = size;
     }
+
+    // Push this instance to the global instances list to automatically destroy
+    instances.push(this);
   }
 
   /**