scripts: address FSharpLint warnings

Contains failing CI.

Author: webwarrior-ws

scripts/checkCommits1by1.fsx

@@ -1231,7 +1231,7 @@ let GitHubApiCall(url: string) =
 ```
 """
 
-                match httpRequestException.StatusCode |> Option.ofNullable with
+                match Option.ofNullable httpRequestException.StatusCode with
                 | Some statusCode when statusCode = HttpStatusCode.NotFound ->
                     if accessTokenName <> "ACCESS_TOKEN" then
                         failwith accessTokenErrorMsg
@@ -1332,7 +1332,7 @@ Please activate GitHub Actions in your repository. Click on the
 let notUsedGitPush1by1 =
     gitHubActionsEnabled
     && ciStatuses.Any(fun (hasCiStatus, shouldHaveCiStatus) ->
-        hasCiStatus = false && shouldHaveCiStatus = true
+        (not hasCiStatus) && shouldHaveCiStatus
     )
 
 if notUsedGitPush1by1 then
@@ -1378,10 +1378,12 @@ prCommits
             // discard check suites for the commit that are not from PR branch
             |> Seq.filter(fun suite -> suite.PullRequests.Length > 0)
             // take the first one (triggered by push); second one is triggered by pull_request
-            |> Seq.head
+            |> Seq.tryHead
 
-        let status = checkSuiteOfInterest.Status
-        let conclusion = checkSuiteOfInterest.Conclusion
+        let status, conclusion =
+            match checkSuiteOfInterest with
+            | Some checkSuite -> checkSuite.Status, checkSuite.Conclusion
+            | None -> failwith "No check suite found"
 
         if status = "completed" && conclusion = "failure" then
             Console.WriteLine()

scripts/deleteAssetsFromOldReleases.fsx

@@ -254,7 +254,7 @@ gitTagsToRemove
         | ex ->
             match FindException<HttpRequestException> ex with
             | Some httpRequestException ->
-                match httpRequestException.StatusCode |> Option.ofNullable with
+                match Option.ofNullable httpRequestException.StatusCode with
                 | Some statusCode when statusCode = HttpStatusCode.Forbidden ->
 
                     failwith githubApiCallForbiddenErrorMsg
@@ -266,7 +266,7 @@ gitTagsToRemove
 
             | _ -> reraise()
 
-    let DeleteAsset (url: string) (accessToken: string) =
+    let deleteAsset (url: string) (accessToken: string) =
         use client = new HttpClient()
         client.DefaultRequestHeaders.Accept.Clear()
         client.DefaultRequestHeaders.Add("User-Agent", userAgent)
@@ -293,7 +293,7 @@ gitTagsToRemove
         | ex ->
             match FindException<HttpRequestException> ex with
             | Some httpRequestException ->
-                match httpRequestException.StatusCode |> Option.ofNullable with
+                match Option.ofNullable httpRequestException.StatusCode with
                 | Some statusCode when statusCode = HttpStatusCode.Forbidden ->
                     failwith githubApiCallForbiddenErrorMsg
                 | _ -> reraise()
@@ -304,6 +304,6 @@ gitTagsToRemove
         let parsedJsonObj = GitHubAssetType.Parse releaseJsonString
 
         parsedJsonObj.Assets
-        |> Seq.iter(fun asset -> DeleteAsset asset.Url githubToken)
+        |> Seq.iter(fun asset -> deleteAsset asset.Url githubToken)
     | _ -> ()
 )

scripts/deleteOldArtifacts.fsx

@@ -133,7 +133,7 @@ let GitHubApiQuery
     | ex ->
         match FindException<HttpRequestException> ex with
         | Some httpRequestException ->
-            match httpRequestException.StatusCode |> Option.ofNullable with
+            match Option.ofNullable httpRequestException.StatusCode with
             | Some statusCode when statusCode = HttpStatusCode.Forbidden ->
 
                 failwith githubApiCallForbiddenErrorMsg
@@ -142,14 +142,14 @@ let GitHubApiQuery
 
         | _ -> reraise()
 
-let hasCIStatus(commit: string) : bool =
+let HasCIStatus(commit: string) : bool =
     let url =
         sprintf
             "https://api.github.com/repos/%s/commits/%s/check-suites"
             githubRepository
             commit
 
-    let mediaTypeWithQuality = "application/vnd.github+json" |> Some
+    let mediaTypeWithQuality = Some "application/vnd.github+json"
 
     let json = GitHubApiQuery url Get mediaTypeWithQuality
 
@@ -158,7 +158,7 @@ let hasCIStatus(commit: string) : bool =
 let userNameOrOrgName = githubRepository.Split("/").[0]
 
 let artifactsApiQueryResult =
-    let mediaTypeWithQuality = "application/vnd.github+json" |> Some
+    let mediaTypeWithQuality = Some "application/vnd.github+json"
 
     let url =
         $"https://api.github.com/repos/{githubRepository}/actions/artifacts"
@@ -204,7 +204,7 @@ let DeleteArtifact (githubRepository: string) (artifactId: string) =
     let url =
         $"https://api.github.com/repos/{githubRepository}/actions/artifacts/{artifactId}"
 
-    GitHubApiQuery url Delete None |> ignore
+    GitHubApiQuery url Delete None |> ignore<string>
 
 let previousCommitsHashes = GetPreviousCommitsHashes()
 
@@ -214,25 +214,23 @@ match whatArtifactsToDelete with
     Console.WriteLine "About to delete only the artifacts of previous commit..."
 
     let previousCommitWithCIStatusOpt =
-        Seq.tryFind hasCIStatus previousCommitsHashes
+        Seq.tryFind HasCIStatus previousCommitsHashes
 
     match previousCommitWithCIStatusOpt with
     | None ->
         Console.WriteLine "No commits found with CI status"
         exit 0
-    | _ -> ()
-
-    let previousCommitWithCIStatus = previousCommitWithCIStatusOpt.Value
-
-    let artifactIdsToDelete =
-        artifactIds
-        |> Seq.filter(fun item ->
-            item.WorkflowRun.HeadSha = previousCommitWithCIStatus
+    | Some previousCommitWithCIStatus ->
+        let artifactIdsToDelete =
+            artifactIds
+            |> Seq.filter(fun item ->
+                item.WorkflowRun.HeadSha = previousCommitWithCIStatus
+            )
+            |> Seq.map(fun artifact -> artifact.Id.ToString())
+
+        artifactIdsToDelete
+        |> Seq.iter(fun artifactId -> DeleteArtifact githubRepository artifactId
         )
-        |> Seq.map(fun artifact -> artifact.Id.ToString())
-
-    artifactIdsToDelete
-    |> Seq.iter(fun artifactId -> DeleteArtifact githubRepository artifactId)
 
 | AllFromBranchlessCommitsAndAllFromPreviousOnesInThisBranch ->
     Console.WriteLine "About to delete all previous artifacts of this branch..."

scripts/gitPush1by1.fsx

@@ -67,13 +67,17 @@ let GitFetch(remoteOpt: Option<string>) =
 let GetLastNthCommitFromRemoteBranch
     (remoteName: string)
     (remoteBranch: string)
-    (n: uint32)
+    (commitNumber: uint32)
     =
     let gitShow =
         {
             Command = "git"
             Arguments =
-                sprintf "show %s/%s~%i --no-patch" remoteName remoteBranch n
+                sprintf
+                    "show %s/%s~%i --no-patch"
+                    remoteName
+                    remoteBranch
+                    commitNumber
         }
 
     let gitShowProcOutput = Process.Execute(gitShow, Echo.Off).UnwrapDefault()
@@ -187,25 +191,22 @@ let maybeRemote, maybeNumberOfCommits, force =
                 "Second argument should be an integer higher than zero"
 
             Environment.Exit 2
-            failwith "Unreachable"
+            failwith "Unreachable because of System.Exit call on previous line (193)"
         | true, num ->
             let numberOfCommits = Some num
             let remote = Some args.[0]
 
             let force =
                 if args.Length = 3 then
-                    if args.[2] = "-f" || args.[2] = "--force" then
-                        true
-                    else
-                        false
+                    args.[2] = "-f" || args.[2] = "--force"
                 else
                     false
 
             remote, numberOfCommits, force
         | _ ->
             Console.Error.WriteLine "Second argument should be an integer"
             Environment.Exit 3
-            failwith "Unreachable"
+            failwith "Unreachable because of System.Exit call on previous line (208)"
     elif args.Length = 0 then
         None, None, false
     else // if args.Length = 1 then
@@ -215,7 +216,7 @@ let maybeRemote, maybeNumberOfCommits, force =
                 "Argument for the number of commits should be an integer higher than zero"
 
             Environment.Exit 2
-            failwith "Unreachable"
+            failwith "Unreachable because of System.Exit call on previous line (218)"
         | true, num ->
             let numberOfCommits = Some num
             let remote = None
@@ -239,7 +240,7 @@ let remote, remoteUrl =
             )
 
             Environment.Exit 4
-            failwith "unreachable"
+            failwith "Unreachable because of System.Exit call on previous line (242)"
         | Some remote -> remote
     | None ->
         if remotes.Count() > 1 then
@@ -266,7 +267,7 @@ let commitsToBePushed =
             )
 
             Environment.Exit 5
-            failwith "Unreachable"
+            failwith "Unreachable because of System.Exit call on previous line (269)"
         elif commitsToPush.Length = 1 then
             // no need to ask for confirmation since 1 commit doesn't need to be separated from other commits
             // (one by one doesn't apply to a length of one)
@@ -280,7 +281,7 @@ let commitsToBePushed =
                     remote
             )
 
-            Console.ReadKey true |> ignore
+            Console.ReadKey true |> ignore<ConsoleKeyInfo>
             Console.WriteLine "Pushing..."
             commitsToPush
     | Some numberOfCommits -> GetLastCommits numberOfCommits

scripts/nonVerboseFlagsInGitHubCIAndScripts.fsx

@@ -21,13 +21,12 @@ let validExtensions =
 
 let invalidFiles =
     validExtensions
-    |> Seq.map(fun ext ->
+    |> Seq.collect(fun ext ->
         Helpers.GetInvalidFiles
             rootDir
             ("*" + ext)
             FileConventions.NonVerboseFlags
     )
-    |> Seq.concat
 
 let message = "Please don't use non-verbose flags in the following files:"
 

scripts/runFSharpLint.fsx

@@ -57,6 +57,11 @@ let targetSolution =
     | None ->
         let solFiles = Directory.GetFiles(targetDir.FullName, "*.sln")
 
+        let getMultipleSolutionsFoundErrorMessage dirName =
+            sprintf
+                "Multiple solution files found in %s; please specify one as an argument"
+                dirName
+
         if solFiles.Length = 0 then
             let solFiles = Directory.GetFiles(fallbackDir.FullName, "*.sln")
 
@@ -66,11 +71,11 @@ let targetSolution =
                     targetDir.FullName
                     fallbackDir.FullName
             elif solFiles.Length > 1 then
-                failwithf
-                    "Multiple solution files found in %s; please specify one as an argument"
-                    fallbackDir.FullName
+                failwith(
+                    getMultipleSolutionsFoundErrorMessage fallbackDir.FullName
+                )
             else
-                let solFile = solFiles.[0] |> FileInfo
+                let solFile = FileInfo solFiles.[0]
 
                 printfn
                     "Using solution file %s from target directory %s"
@@ -79,11 +84,9 @@ let targetSolution =
 
                 solFile
         elif solFiles.Length > 1 then
-            failwithf
-                "Multiple solution files found in %s; please specify one as an argument"
-                targetDir.FullName
+            failwith(getMultipleSolutionsFoundErrorMessage targetDir.FullName)
         else
-            let solFile = solFiles.[0] |> FileInfo
+            let solFile = FileInfo solFiles.[0]
 
             printfn
                 "Using solution file %s from target directory %s"