Product reviews fixes (#4)

* Product reviews fixes
1. fix image url
2. add http response codes for debugging

* Avoid code repetition

* Remove Exception import

Author: to6ko12

common/src/Module.php

@@ -98,13 +98,13 @@ private function sendSyncUrl(): void {
         ];
         try {
             $this->doSendSyncUrl($url, $data);
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             PrestaShopLogger::addLog(sprintf('Sending sync URL to Dashboard failed with error %s', $e->getMessage()));
         }
     }
 
     /**
-     * @throws Exception
+     * @throws \Exception
      */
     private function doSendSyncUrl(string $url, array $data): void {
         $curl = curl_init();
@@ -119,12 +119,12 @@ private function doSendSyncUrl(string $url, array $data): void {
             CURLOPT_TIMEOUT => 10,
         ];
         if (!curl_setopt_array($curl, $options)) {
-            throw new Exception('Could not set cURL options');
+            throw new \Exception('Could not set cURL options');
         }
 
         $response = curl_exec($curl);
         if ($response === false) {
-            throw new Exception(sprintf('(%s) %s', curl_errno($curl), curl_error($curl)));
+            throw new \Exception(sprintf('(%s) %s', curl_errno($curl), curl_error($curl)));
         }
 
         curl_close($curl);
@@ -466,7 +466,7 @@ private function getProductImage($product): string {
         $context = Context::getContext();
         $img = $product->getCover($product->id);
 
-        return str_replace('http://', Tools::getShopProtocol(), $context->link->getImageLink($img['link_rewrite'], $img['id_image'], 'large_default'));
+        return str_replace('http://', Tools::getShopProtocol(), $context->link->getImageLink($product->link_rewrite, $img['id_image'], 'home_default'));
     }
 
     public function hookBackofficeTop() {

common/src/Sync.php

@@ -6,55 +6,47 @@
 use Customer;
 use DateTime;
 use Doctrine\ORM\EntityManagerInterface;
-use Exception;
 use ModuleFrontController;
 use PrestaShop\Module\ProductComment\Entity\ProductComment;
 use PrestaShop\PrestaShop\Adapter\Validate;
 use Product;
-use Symfony\Component\HttpKernel\Exception\HttpException;
 
 class Sync extends ModuleFrontController {
 
     /** @var bool */
     public $ajax;
 
-    /**
-     * @throws Exception
-     */
     public function postProcess(): void {
         $request_data = trim(file_get_contents('php://input'));
         if (!$request_data) {
-            throw new HttpException(400, 'Empty request data');
+            $this->returnResponseCode(400, 'Empty request data.');
         }
         if (!$request_data = json_decode($request_data, true)) {
-            throw new HttpException(400, 'Invalid JSON data provided');
+            $this->returnResponseCode(400, 'Invalid JSON data provided.');
         }
 
         if (
             !$this->hasCredentialFields($request_data['webshop_id'], $request_data['api_key'])
             || $this->credentialsEmpty($request_data['webshop_id'], $request_data['api_key'])
         ) {
-            throw new HttpException(403, 'Missing credential fields');
+            $this->returnResponseCode(403, 'Missing credential fields.');
         }
 
         $this->isAuthorized($request_data['webshop_id'], $request_data['api_key']);
 
         $lang_id = (int) Configuration::get('PS_LANG_DEFAULT');
         $product = new Product($request_data['product_review']['product_id'], false, $lang_id);
         if (!Validate::isLoadedObject($product)) {
-            throw new HttpException(404, sprintf('Could not find product with ID (%d)', $request_data['product_review']['product_id']));
+            $this->returnResponseCode(404, sprintf('Could not find product with ID (%d)', $request_data['product_review']['product_id']));
         }
 
         if (!Configuration::get($this->module->getConfigName('SYNC_PROD_REVIEWS'))) {
-            throw new HttpException(403, 'Product review sync is disabled.');
+            $this->returnResponseCode(403, 'Product review sync is disabled.');
         }
 
         $this->syncProductReview($request_data['product_review']);
     }
 
-    /**
-     * @throws Exception
-     */
     private function syncProductReview(array $product_review): void {
         $this->ajax = 1;
         /** @var EntityManagerInterface $entityManager */
@@ -92,16 +84,13 @@ private function logReviewSync(string $review_id, bool $deleted = false): void {
         \PrestaShopLogger::addLog(sprintf('%s product review with ID (%d)', $deleted ? 'Deleted' : 'Saved', $review_id));
     }
 
-    /**
-     * @throws Exception
-     */
     private function isAuthorized(string $webshop_id, string $api_key): void {
         $curr_webshop_id = Configuration::get($this->module->getConfigName('SHOP_ID'));
         $curr_api_key = Configuration::get($this->module->getConfigName('API_KEY'));
         if ($webshop_id == $curr_webshop_id && hash_equals($api_key, $curr_api_key)) {
             return;
         }
-        throw new HttpException(401, 'Wrong credentials');
+        $this->returnResponseCode(401, 'Wrong credentials.');
     }
 
     private function hasCredentialFields(?string $webshop_id, ?string $api_key): bool {
@@ -111,4 +100,9 @@ private function hasCredentialFields(?string $webshop_id, ?string $api_key): boo
     private function credentialsEmpty(?string $webshop_id, ?string $api_key): bool {
         return !trim($webshop_id) || !trim($api_key);
     }
+
+    private function returnResponseCode(int $code, string $message): void {
+        http_response_code($code);
+        die($message);
+    }
 }