fix: issue #58

Author: TtTRz

demo/computed/behavior.js

@@ -22,6 +22,7 @@ interface ComputedWatchInfo {
   computedUpdaters: Array<any>;
   computedRelatedPathValues: Record<string, any>;
   watchCurVal: Record<string, any>;
+  _triggerFromComputedAttached: Record<string, boolean>;
 }
 
 let computedWatchDefIdInc = 0;
@@ -55,6 +56,7 @@ export const behavior = Behavior({
             computedUpdaters: [],
             computedRelatedPathValues: {},
             watchCurVal: {},
+            _triggerFromComputedAttached: {},
           };
           if (!this._computedWatchInfo) this._computedWatchInfo = {};
           this._computedWatchInfo[computedWatchDefId] = computedWatchInfo;
@@ -94,7 +96,7 @@ export const behavior = Behavior({
               this.setData({
                 [targetField]: dataTracer.unwrap(val),
               });
-
+              computedWatchInfo._triggerFromComputedAttached[targetField] = true;
               computedWatchInfo.computedRelatedPathValues[targetField] =
                 pathValues;
 
@@ -153,6 +155,7 @@ export const behavior = Behavior({
     }
 
     if (watchDef) {
+
       Object.keys(watchDef).forEach((watchPath) => {
         const paths = dataPath.parseMultiDataPaths(watchPath);
         observersItems.push({
@@ -162,6 +165,19 @@ export const behavior = Behavior({
             const computedWatchInfo =
               this._computedWatchInfo[computedWatchDefId];
             if (!computedWatchInfo) return;
+            // (issue #58) ignore watch func when trigger by computed attached
+            if (Object.keys(computedWatchInfo._triggerFromComputedAttached).length) {
+              const pathsMap: Record<string, boolean> = {}
+              paths.forEach((path) => pathsMap[path.path[0]] = true);
+              for (let computedVal in computedWatchInfo._triggerFromComputedAttached) {
+                if (computedWatchInfo._triggerFromComputedAttached.hasOwnProperty(computedVal)) {
+                  if (pathsMap[computedVal]) {
+                    computedWatchInfo._triggerFromComputedAttached[computedVal] = false;
+                    return
+                  }
+                }
+              }
+            }
             const oldVal = computedWatchInfo.watchCurVal[watchPath];
 
             // get new watching field value
@@ -204,6 +220,7 @@ export const behavior = Behavior({
     if (typeof defFields.observers !== "object") {
       defFields.observers = {};
     }
+
     if (Array.isArray(defFields.observers)) {
       defFields.observers.push(...observersItems);
     } else {

dist/index.js

@@ -3,12 +3,12 @@ const WHITE_SPACE_CHAR_REGEXP = /^\s/;
 const throwParsingError = function (path, index) {
   throw new Error(
     'Parsing data path "' +
-      path +
-      '" failed at char "' +
-      path[index] +
-      '" (index ' +
-      index +
-      ")"
+    path +
+    '" failed at char "' +
+    path[index] +
+    '" (index ' +
+    index +
+    ")"
   );
 };
 

src/behavior.ts

@@ -1,6 +1,5 @@
 const wrapData = (data, relatedPathValues, basePath) => {
   if (typeof data !== "object" || data === null) return data;
-
   const handler = {
     get(_obj, key) {
       if (key === "__rawObject__") return data;
@@ -22,6 +21,7 @@ const wrapData = (data, relatedPathValues, basePath) => {
 export function create(data, relatedPathValues) {
   return wrapData(data, relatedPathValues, []);
 }
+
 export function unwrap(wrapped) {
   if (
     typeof wrapped !== "object" ||

src/data-path.ts

@@ -776,4 +776,53 @@ describe("computed behavior", () => {
     expect(c1TriggerCount).toBe(2);
     expect(c2TriggerCount).toBe(2);
   });
+
+  test("ignore watch func when trigger by computed attached", () => {
+    let cTriggerCount = 0;
+    let dTriggerCount = 0;
+    const behA = BehaviorWithComputed({
+      data: {
+        a: 1,
+      },
+      computed: {
+        d(data) {
+          return 10
+        },
+        c(data) {
+          return data.b * 2;
+        },
+      },
+      watch: {
+        c() {
+          cTriggerCount += 1;
+        },
+        d() {
+          dTriggerCount += 1;
+        },
+      },
+      attached() {
+        this.setData({
+          a: 2,
+        });
+      },
+    });
+    const componentId = _.load({
+      template: "<view>{{c}}</view>",
+      behaviors: [behA, computedBehavior],
+      data: {
+        b: 10,
+      },
+      attached() {
+        this.setData({
+          b: 20,
+        });
+      },
+    });
+    const component = _.render(componentId);
+    component.triggerLifeTime("attached");
+    expect(_.match(component.dom!, "<wx-view>40</wx-view>")).toBe(true);
+    expect(cTriggerCount).toBe(0);
+    expect(dTriggerCount).toBe(0);
+
+  })
 });