Unvoting #325

weiran · 2025-11-02T10:56:56Z

Implement the ability to unvote posts and comments within the 1-hour window that Hacker News allows. The unvote option appears automatically when an unvote link is available from the server.

Changes:

Add unvote methods to VoteUseCase protocol
Implement unvote in PostRepository for posts and comments
Update VotingState to track unvote availability with canUnvote property
Add unvote to VotingStateProvider protocol and DefaultVotingStateProvider
Update VotingViewModel with unvote methods and optimistic UI updates
Update VoteButton to enable interaction when unvote is available
Add unvote options to VotingContextMenuItems for posts and comments
Update PostDisplayView to support unvote with toggle between upvote/unvote
Add unvote swipe actions and context menus in FeedView
Add unvote swipe actions and context menus in CommentsView for posts and comments

The feature includes:

Optimistic UI updates with automatic rollback on error
Swipe actions (orange arrow.uturn.down icon for unvote)
Context menu options
Proper accessibility labels and hints
Automatic detection of unvote availability based on server response

Summary by CodeRabbit

New Features
- Users can now remove (undo) upvotes on posts and comments via vote buttons, context menus and swipe actions.
- UI shows when unvoting is available, updates accessibility labels/hints, and preserves visual state during unvote flows.
- Feed, comments and search synchronise updated posts after unvote.
Bug Fixes
- Optimistic unvote updates with automatic rollback on error; handles unauthenticated cases gracefully.
Tests
- Added test coverage for unvote behaviour across multiple suites.

Implement the ability to unvote posts and comments within the 1-hour window that Hacker News allows. The unvote option appears automatically when an unvote link is available from the server. Changes: - Add unvote methods to VoteUseCase protocol - Implement unvote in PostRepository for posts and comments - Update VotingState to track unvote availability with canUnvote property - Add unvote to VotingStateProvider protocol and DefaultVotingStateProvider - Update VotingViewModel with unvote methods and optimistic UI updates - Update VoteButton to enable interaction when unvote is available - Add unvote options to VotingContextMenuItems for posts and comments - Update PostDisplayView to support unvote with toggle between upvote/unvote - Add unvote swipe actions and context menus in FeedView - Add unvote swipe actions and context menus in CommentsView for posts and comments The feature includes: - Optimistic UI updates with automatic rollback on error - Swipe actions (orange arrow.uturn.down icon for unvote) - Context menu options - Proper accessibility labels and hints - Automatic detection of unvote availability based on server response

coderabbitai · 2025-11-02T10:57:05Z

Warning

Rate limit exceeded

@weiran has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 445d55d and 9a09fce.

📒 Files selected for processing (4)

Features/Comments/Sources/Comments/CommentsComponents.swift (10 hunks)
Features/Feed/Sources/Feed/FeedView.swift (8 hunks)
Features/Feed/Sources/Feed/FeedViewModel.swift (1 hunks)
Shared/Sources/Shared/ViewModels/VotingViewModel.swift (9 hunks)

Walkthrough

Adds unvote support across layers: repository methods, domain use‑case and state, voting state provider, view models, UI components (buttons, context menus, post display), and tests; introduces VotingState.canUnvote and wires unvote flows with optimistic UI updates and error rollback.

Changes

Cohort / File(s)	Summary
Repository & Data Layer `Data/Sources/Data/PostRepository+Voting.swift`	Adds `public func unvote(post: Post) async throws` and `public func unvote(comment: Domain.Comment, for _: Post) async throws` that resolve `voteLinks.unvote`, build absolute/relative URLs, perform GET, and detect login form/hint to throw unauthenticated.
Domain Models `Domain/Sources/Domain/Models.swift`	Adds `public let canUnvote: Bool` to `VotingState` and extends its initializer to accept `canUnvote: Bool = false`.
Domain Use Cases & Providers `Domain/Sources/Domain/VoteUseCase.swift`, `Domain/Sources/Domain/VotingStateProvider.swift`	Adds `unvote(post:)` and `unvote(comment:for:)` to `VoteUseCase`; extends `VotingStateProvider` with `unvote(item: any Votable)` and `unvoteComment(_:for:)`; `DefaultVotingStateProvider` delegates unvote to `voteUseCase` and derives `canUnvote` from `item.voteLinks?.unvote`.
Design System: Post Display `DesignSystem/Sources/DesignSystem/Components/PostDisplayView.swift`	Adds public `onUnvoteTap` property/initializer param; introduces `displayedVoteLinks` synced from `post.voteLinks`; implements unvote path in vote action with optimistic update, rollback on failure, and exposes `onUnvote` in `PostContextMenu`.
Design System: Voting UI `DesignSystem/Sources/DesignSystem/Components/VoteButton.swift`, `DesignSystem/Sources/DesignSystem/Components/VotingContextMenuItems.swift`	Adjusts disabled-state logic to allow interaction when only `canUnvote` is true; updates accessibility labels/hints for unvote; threads `onUnvote` callback through voting menu builders and renders an Unvote option when applicable.
Shared View Models `Shared/Sources/Shared/ViewModels/VotingViewModel.swift`	Adds `unvote(post: inout Post) async`, `unvote(comment: Comment, in post: Post) async`, `canUnvote(item: any Votable) -> Bool` and helpers to derive/apply unvote links; propagates `canUnvote` into returned `VotingState`; implements optimistic updates with revert on error.
Features: Feed `Features/Feed/Sources/Feed/FeedView.swift`, `Features/Feed/Sources/Feed/FeedViewModel.swift`	Replaces `onUpvoteApplied` with `onPostUpdated(Post)` and adds `onUnvoteTap`; implements `handleUnvoteTap()` and unvote flows in swipe actions and context menus; `FeedViewModel.replacePost()` now updates both feedLoader and searchResults; `PostRowView` and `PostDisplayView` wired to pass `onUnvoteTap`.
Features: Comments `Features/Comments/Sources/Comments/CommentsComponents.swift`, `Features/Comments/Sources/Comments/CommentsView.swift`, `Features/Comments/Sources/Comments/CommentsViewModel.swift`	Replaces `onUpvoteApplied` with `onPostUpdated(Post)`; adds `onUnvoteTap` and `handleUnvote()` in `PostHeader`; wires `onUnvote` through voting context menus and swipe actions for posts and comments; CommentsViewModel exposes `onPostUpdated` and triggers it when `post` changes; CommentsView wires onPostUpdated to navigationStore.selectedPost.
Tests / Mocks / Stubs multiple test files (e.g., `Features/Comments/Tests/...`, `Features/Feed/Tests/...`, `Shared/Tests/.../VotingViewModelTests.swift`, `Shared/Tests/.../DependencyContainerTests.swift`)	Adds `unvote(post:)` and `unvote(comment:for:)` stubs/mocks across tests and providers; updates Stub/Mock providers and VotingViewModel tests; adds tests asserting that upvote synthesises an unvote URL when missing (preserves how=un, auth token, goto param).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI as PostDisplayView
    participant VM as VotingViewModel
    participant UseCase as VoteUseCase
    participant Repo as PostRepository
    participant API as Remote API

    User->>UI: Tap Unvote
    UI->>VM: unvote(post: inout Post)
    Note over VM: Optimistic update — upvoted=false, score -= 1
    VM->>UseCase: unvote(post)
    UseCase->>Repo: unvote(post)
    Repo->>API: GET unvote URL
    alt Success
        API-->>Repo: 200 OK
        Repo-->>UseCase: success
        UseCase-->>VM: success
        VM-->>UI: confirm update (post replaced)
        UI->>User: shows unvoted state
    else Failure / Unauthenticated
        API-->>Repo: Login form / hint or error
        Repo-->>UseCase: throws
        UseCase-->>VM: throws
        Note over VM: Revert optimistic update — restore upvoted and score
        VM-->>UI: error + reverted state
        UI->>User: error indication, state restored
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Heterogeneous changes across data, domain, view‑model, UI and tests.
Areas for extra attention:
- PostDisplayView.swift & VoteButton.swift: displayedVoteLinks sync, interaction/disabled states, accessibility texts.
- VotingViewModel.swift: optimistic unvote logic, synthesis/derivation of unvote URLs, rollback on error.
- VotingStateProvider.swift / DefaultVotingStateProvider: correct delegation and canUnvote derivation.
- Tests that assert synthesized unvote URLs: verify preserved query params (how, auth token, goto) and behaviour when original unvote link is absent.

Possibly related PRs

SwiftUI Migration #302 — overlapping unvote additions and voting-state wiring; likely intersects on voteLinks, VoteUseCase and UI wiring.
Clean Architecture Rewrite #304 — related voting changes and UI primitives that this PR extends with unvote flows.

Poem

I hopped to the button, then hopped back again,
A nibble of code to return what was spent.
If networks protest and the rollback must run,
I fluff up my tail and restore every one. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title "Unvoting" directly and concisely describes the primary feature being implemented across the entire changeset.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)

DesignSystem/Sources/DesignSystem/Components/VoteButton.swift (1)
103-110: Fix interactive tint when only unvote is available.

With the new .disabled((!votingState.canVote && !votingState.canUnvote) || votingState.isVoting) the button stays enabled during the unvote window, but foregroundColor(for:) still returns disabledColor whenever canVote is false. For items that are upvoted with only an unvote link, the control is now actionable yet rendered in the disabled tint, which is misleading and hurts accessibility. Please gate the disabled tint on both canVote and canUnvote, e.g.:
     public func foregroundColor(for state: VotingState) -> Color {
-        if !state.canVote {
+        if !state.canVote && !state.canUnvote {
             disabledColor
         } else if state.isUpvoted {
             upvotedColor
         } else {
             defaultColor
         }
     }
Features/Feed/Sources/Feed/FeedView.swift (1)

215-276: Local unvote still re-applies the upvote
Both the leading swipe unvote action and the context-menu unvote branch call viewModel.applyLocalUpvote(to:) after VotingViewModel.unvote. That helper unconditionally sets upvoted = true and bumps the score, so the list row reverts to “upvoted” immediately even though the backend call succeeded. Please introduce a symmetric helper (e.g. applyLocalUnvote) that clears the flag and decrements the score, and invoke it from the unvote paths instead of applyLocalUpvote.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a725036 and 812ccc7.

📒 Files selected for processing (10)

Data/Sources/Data/PostRepository+Voting.swift (2 hunks)
DesignSystem/Sources/DesignSystem/Components/PostDisplayView.swift (8 hunks)
DesignSystem/Sources/DesignSystem/Components/VoteButton.swift (1 hunks)
DesignSystem/Sources/DesignSystem/Components/VotingContextMenuItems.swift (4 hunks)
Domain/Sources/Domain/Models.swift (1 hunks)
Domain/Sources/Domain/VoteUseCase.swift (1 hunks)
Domain/Sources/Domain/VotingStateProvider.swift (3 hunks)
Features/Comments/Sources/Comments/CommentsComponents.swift (7 hunks)
Features/Feed/Sources/Feed/FeedView.swift (5 hunks)
Shared/Sources/Shared/ViewModels/VotingViewModel.swift (4 hunks)

🧰 Additional context used

📓 Path-based instructions (7)

DesignSystem/**/Sources/**/*.swift