removed illegal reflective access; sidebar of JFileChooser now filters out all the "Backups of" pseudo-volumes from TimeMachine.

Author: weirdkid

README.md

@@ -15,24 +15,16 @@ Now that JavaFX is being spun out of Java, some may yet still find this useful.
 
 Requirements/Dependencies
 ------------
-- Java 8
+- Java 8, but tested with Java 11 and 17
 - TwelveMonkeys ImageIO 3.5-SNAPSHOT or newer, include these artifacts:
   - core
   - metadata
   - icns
 
-Illegal Reflective Access Warnings in JDK9+
------------
-To hide the warnings about illegal reflective access, launch your app with the jvm parameter:
-
-java --add-opens java.desktop/com.apple.laf=ALL-UNNAMED ...
-
-This will hide the warnings, but this does not fix the issue. Future jdk could remove the ability to force allowing the reflective access if not explicity allowed by the library. 
-
 
 Code notes:
 -----------
 
-- There are variations of the UI for every version of macOS up through Mavericks, but the last one to not rely on native code was the QuaquaLeopardFileChooserUI, so that's where my effort is focused. The QuaquaManager only provides this option for UI now.
-- QuaquaFileSystemView picks a macOS version-specific implementation of a FileSystemView. Ever since Lion, they all use OSXLionFileSystemView, so that's also where I focus.
+- There are variations of the UI for every version of macOS up through Mavericks, but the last one to not rely on native code was the QuaquaLeopardFileChooserUI. The QuaquaManager only provides this option for UI now.
+- QuaquaFileSystemView picks a macOS version-specific implementation of a FileSystemView. Ever since Lion, they all use OSXLionFileSystemView.
 

pom.xml

@@ -5,7 +5,7 @@
 
 	<groupId>com.weirdkid</groupId>
 	<artifactId>quaqua-jfc</artifactId>
-	<version>24.02</version>
+	<version>25.6</version>
 
 	<name>Quaqua-JFC</name>
 	<description>Pure Java JFileChooser for Mac, forked from Quaqua LAF</description>

src/main/java/ch/randelshofer/quaqua/leopard/filechooser/SidebarTreeModel.java

@@ -15,6 +15,7 @@
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.HashMap;
+import java.net.InetAddress;
 
 import javax.swing.Icon;
 import javax.swing.JFileChooser;
@@ -79,6 +80,18 @@ public class SidebarTreeModel extends DefaultTreeModel implements TreeModelListe
 			new File(QuaquaManager.getProperty("user.home"), "Desktop"),
 			new File(QuaquaManager.getProperty("user.home"), "Documents") };
 
+	private final String backupPrefix = "Backups of ";
+	// this is unreliable on macOS
+	//	{
+//		String computerName;
+//		try {
+//			computerName = InetAddress.getLocalHost().getHostName();
+//		} catch (Exception e) {
+//			computerName = ""; // fallback if hostname can't be determined
+//		}
+//		backupPrefix = "Backups of " + computerName;
+//	}
+
 	/** Creates a new instance. */
 	public SidebarTreeModel(JFileChooser fileChooser, TreePath path, TreeModel model) {
 		super(new DefaultMutableTreeNode(), true);
@@ -157,7 +170,8 @@ private void updateDevicesNode() {
 		// in the view. Only add non-leaf nodes
 		for (int i = 0, n = modelDevicesNode.getChildCount(); i < n; i++) {
 			FileSystemTreeModel.Node modelNode = (FileSystemTreeModel.Node) modelDevicesNode.getChildAt(i);
-			if (!modelNode.isLeaf()) {
+			String deviceName = modelNode.getUserName();
+			if (!modelNode.isLeaf() && !(deviceName != null && deviceName.startsWith(backupPrefix))) {
 				boolean isInView = false;
 				for (int j = 0, m = devicesNode.getChildCount(); j < m; j++) {
 					SidebarViewToModelNode viewNode = (SidebarViewToModelNode) devicesNode.getChildAt(j);

src/main/java/ch/randelshofer/quaqua/subset/QuaquaLeopardFileChooserLAF.java

@@ -96,17 +96,39 @@ public class QuaquaLeopardFileChooserLAF extends LookAndFeelProxy {
 	/**
 	 * Creates a new instance.
 	 */
+//	public QuaquaLeopardFileChooserLAF() {
+//		// System.out.println(UIManager.getSystemLookAndFeelClassName());
+//		String targetClassName = "com.apple.laf.AquaLookAndFeel";
+//		try {
+//			setTarget((LookAndFeel) Class.forName(targetClassName).getDeclaredConstructor().newInstance());
+//		} catch (Exception e) {
+//			throw new InternalError(
+//					"Unable to instanciate target Look and Feel \"" + targetClassName + "\". " + e.getMessage());
+//		}
+//	}
+
 	public QuaquaLeopardFileChooserLAF() {
-		// System.out.println(UIManager.getSystemLookAndFeelClassName());
-		String targetClassName = "com.apple.laf.AquaLookAndFeel";
+		String targetClassName = UIManager.getSystemLookAndFeelClassName();
+
+		//System.out.println("QuaquaLeopardFileChooserLAF: Using target Look and Feel: " + targetClassName);
+		// only install Quaqua on macOS/Aqua
+//		if (!"com.apple.laf.AquaLookAndFeel".equals(targetClassName)) {
+//			return;
+//		}
 		try {
-			setTarget((LookAndFeel) Class.forName(targetClassName).getDeclaredConstructor().newInstance());
-		} catch (Exception e) {
+			// ask UIManager (inside java.desktop) to load it
+			UIManager.setLookAndFeel(targetClassName);
+			setTarget( UIManager.getLookAndFeel() );
+		}
+		catch (Exception e) {
 			throw new InternalError(
-					"Unable to instanciate target Look and Feel \"" + targetClassName + "\". " + e.getMessage());
+					"Unable to instantiate system L&F \"" + targetClassName + "\": " + e
+			);
 		}
 	}
 
+
+
 	/**
 	 * Return a one line description of this look and feel implementation, e.g. "The
 	 * CDE/Motif Look and Feel". This string is intended for the user, e.g. in the