SSL offloading: more and more unit tests

Author: weizhouapache

server/src/test/java/com/cloud/network/lb/LoadBalancingRulesManagerImplTest.java

@@ -92,6 +92,14 @@ public class LoadBalancingRulesManagerImplTest{
     @InjectMocks
     LoadBalancingRulesManagerImpl lbr = new LoadBalancingRulesManagerImpl();
 
+    @Mock
+    LoadBalancerVO loadBalancerMock;
+
+    private long accountId = 10L;
+    private long lbRuleId = 2L;
+    private long certMapRuleId = 3L;
+    private long networkId = 4L;
+
     @Test
     public void generateCidrStringTestNullCidrList() {
         String result = lbr.generateCidrString(null);
@@ -179,21 +187,15 @@ public void testAssignCertToLoadBalancer() throws Exception {
         Mockito.verify(lbr, times(2)).applyLoadBalancerConfig(lbRuleId);
     }
 
-    @Test
-    public void testUpdateLoadBalancerRule1() throws Exception {
-        long accountId = 10L;
-        long lbRuleId = 2L;
-        long certMapRuleId = 3L;
-        long networkId = 4L;
-
+    private void setupUpdateLoadBalancerRule() throws Exception{
         AccountVO account = new AccountVO("testaccount", 1L, "networkdomain", Account.Type.NORMAL, "uuid");
         account.setId(accountId);
         UserVO user = new UserVO(1, "testuser", "password", "firstname", "lastName", "email", "timezone",
                 UUID.randomUUID().toString(), User.Source.UNKNOWN);
         CallContext.register(user, account);
 
-        LoadBalancerVO loadBalancerMock = Mockito.mock(LoadBalancerVO.class);
         when(_lbDao.findById(lbRuleId)).thenReturn(loadBalancerMock);
+        when(loadBalancerMock.getId()).thenReturn(lbRuleId);
         when(loadBalancerMock.getNetworkId()).thenReturn(networkId);
 
         NetworkVO network = Mockito.mock(NetworkVO.class);
@@ -208,7 +210,16 @@ public void testUpdateLoadBalancerRule1() throws Exception {
 
         when(_lbDao.update(lbRuleId, loadBalancerMock)).thenReturn(true);
 
-        // Replace TCP with SSL
+        LoadBalancerCertMapVO certMapRule = Mockito.mock(LoadBalancerCertMapVO.class);
+        when(_lbCertMapDao.findByLbRuleId(lbRuleId)).thenReturn(certMapRule);
+        when(certMapRule.getId()).thenReturn(certMapRuleId);
+    }
+
+    @Test
+    public void testUpdateLoadBalancerRule1() throws Exception {
+        setupUpdateLoadBalancerRule();
+
+        // Update protocol from TCP to SSL
         UpdateLoadBalancerRuleCmd cmd = new UpdateLoadBalancerRuleCmd();
         ReflectionTestUtils.setField(cmd, ApiConstants.ID, lbRuleId);
         ReflectionTestUtils.setField(cmd, "lbProtocol", NetUtils.SSL_PROTO);
@@ -222,46 +233,53 @@ public void testUpdateLoadBalancerRule1() throws Exception {
 
     @Test
     public void testUpdateLoadBalancerRule2() throws Exception {
-        long accountId = 10L;
-        long lbRuleId = 2L;
-        long certMapRuleId = 3L;
-        long networkId = 4L;
+        setupUpdateLoadBalancerRule();
 
-        AccountVO account = new AccountVO("testaccount", 1L, "networkdomain", Account.Type.NORMAL, "uuid");
-        account.setId(accountId);
-        UserVO user = new UserVO(1, "testuser", "password", "firstname", "lastName", "email", "timezone",
-                UUID.randomUUID().toString(), User.Source.UNKNOWN);
-        CallContext.register(user, account);
+        // Update protocol from SSL to TCP
+        UpdateLoadBalancerRuleCmd cmd = new UpdateLoadBalancerRuleCmd();
+        ReflectionTestUtils.setField(cmd, ApiConstants.ID, lbRuleId);
+        ReflectionTestUtils.setField(cmd, "lbProtocol", NetUtils.TCP_PROTO);
+        when(loadBalancerMock.getLbProtocol()).thenReturn(NetUtils.SSL_PROTO).thenReturn(NetUtils.TCP_PROTO);
 
-        LoadBalancerVO loadBalancerMock = Mockito.mock(LoadBalancerVO.class);
-        when(_lbDao.findById(lbRuleId)).thenReturn(loadBalancerMock);
-        when(loadBalancerMock.getId()).thenReturn(lbRuleId);
-        when(loadBalancerMock.getNetworkId()).thenReturn(networkId);
+        lbr.updateLoadBalancerRule(cmd);
 
-        NetworkVO network = Mockito.mock(NetworkVO.class);
-        when(_networkDao.findById(networkId)).thenReturn(network);
+        Mockito.verify(_lbCertMapDao, times(1)).remove(anyLong());
+        Mockito.verify(lbr, times(1)).applyLoadBalancerConfig(lbRuleId);
+    }
 
-        Mockito.doNothing().when(_accountMgr).checkAccess(Mockito.any(Account.class), Mockito.isNull(SecurityChecker.AccessType.class), Mockito.eq(true), Mockito.any(LoadBalancerVO.class));
+    @Test
+    public void testUpdateLoadBalancerRule3() throws Exception {
+        setupUpdateLoadBalancerRule();
 
-        LoadBalancingRule loadBalancingRule = Mockito.mock(LoadBalancingRule.class);
-        Mockito.doReturn(loadBalancingRule).when(lbr).getLoadBalancerRuleToApply(loadBalancerMock);
-        Mockito.doReturn(true).when(lbr).validateLbRule(loadBalancingRule);
-        Mockito.doReturn(true).when(lbr).applyLoadBalancerConfig(lbRuleId);
+        // Update algorithm from source to roundrobin, lb protocol is same
+        UpdateLoadBalancerRuleCmd cmd = new UpdateLoadBalancerRuleCmd();
+        ReflectionTestUtils.setField(cmd, ApiConstants.ID, lbRuleId);
+        ReflectionTestUtils.setField(cmd, "algorithm", "roundrobin");
+        ReflectionTestUtils.setField(cmd, "lbProtocol", NetUtils.SSL_PROTO);
+        when(loadBalancerMock.getAlgorithm()).thenReturn("source");
+        when(loadBalancerMock.getLbProtocol()).thenReturn(NetUtils.SSL_PROTO);
 
-        when(_lbDao.update(lbRuleId, loadBalancerMock)).thenReturn(true);
+        lbr.updateLoadBalancerRule(cmd);
+
+        Mockito.verify(lbr, times(1)).applyLoadBalancerConfig(lbRuleId);
+        Mockito.verify(_lbCertMapDao, never()).remove(anyLong());
+    }
 
-        // Replace SSL with TCP
+    @Test
+    public void testUpdateLoadBalancerRule4() throws Exception {
+        setupUpdateLoadBalancerRule();
+
+        // Update with same algorithm and protocol
         UpdateLoadBalancerRuleCmd cmd = new UpdateLoadBalancerRuleCmd();
         ReflectionTestUtils.setField(cmd, ApiConstants.ID, lbRuleId);
-        ReflectionTestUtils.setField(cmd, "lbProtocol", NetUtils.TCP_PROTO);
-        LoadBalancerCertMapVO certMapRule = Mockito.mock(LoadBalancerCertMapVO.class);
-        when(_lbCertMapDao.findByLbRuleId(lbRuleId)).thenReturn(certMapRule);
-        when(certMapRule.getId()).thenReturn(certMapRuleId);
-        when(loadBalancerMock.getLbProtocol()).thenReturn(NetUtils.SSL_PROTO).thenReturn(NetUtils.TCP_PROTO);
+        ReflectionTestUtils.setField(cmd, "algorithm", "roundrobin");
+        ReflectionTestUtils.setField(cmd, "lbProtocol", NetUtils.SSL_PROTO);
+        when(loadBalancerMock.getAlgorithm()).thenReturn("roundrobin");
+        when(loadBalancerMock.getLbProtocol()).thenReturn(NetUtils.SSL_PROTO);
 
         lbr.updateLoadBalancerRule(cmd);
 
-        Mockito.verify(_lbCertMapDao, times(1)).remove(anyLong());
-        Mockito.verify(lbr, times(1)).applyLoadBalancerConfig(lbRuleId);
+        Mockito.verify(lbr, never()).applyLoadBalancerConfig(lbRuleId);
+        Mockito.verify(_lbCertMapDao, never()).remove(anyLong());
     }
 }