Skip to content

Commit b14c0ef

Browse files
authored
Merge pull request #1030 from wellyshen/migrate-googlemaps-types
Replace `@types/googlemaps` with `@types/google.maps`
2 parents 5016e17 + 11e909a commit b14c0ef

6 files changed

Lines changed: 20 additions & 20 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ $ yarn add use-places-autocomplete
4646
$ npm install --save use-places-autocomplete
4747
```
4848

49-
When working with TypeScript you need to install the [@types/googlemaps](https://www.npmjs.com/package/@types/googlemaps) as a `devDependencies`.
49+
When working with TypeScript you need to install the [@types/google.maps](https://www.npmjs.com/package/@types/google.maps) as a `devDependencies`.
5050

5151
```sh
52-
$ yarn add --dev @types/googlemaps
52+
$ yarn add --dev @types/google.maps
5353
# or
54-
$ npm install --save-dev @types/googlemaps
54+
$ npm install --save-dev @types/google.maps
5555
```
5656

5757
## Getting Started

app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"use-places-autocomplete": "latest"
4040
},
4141
"devDependencies": {
42-
"@types/googlemaps": "^3.43.3",
42+
"@types/google.maps": "^3.49.2",
4343
"eslint-config-welly": "^1.13.0",
4444
"npm-run-all": "^4.1.5",
4545
"postcss-scss": "^4.0.4",

app/yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1800,10 +1800,10 @@
18001800
"@types/qs" "*"
18011801
"@types/serve-static" "*"
18021802

1803-
"@types/googlemaps@^3.43.3":
1804-
version "3.43.3"
1805-
resolved "https://registry.yarnpkg.com/@types/googlemaps/-/googlemaps-3.43.3.tgz#70cf962154a160fe78bcd69d6ccc296dd9175b1f"
1806-
integrity sha512-ZWNoz/O8MPEpiajvj7QiqCY8tTLFNqNZ/a+s+zTV58wFVNAvvqV4bdGfnsjTb5Cs4V6wEsLrX8XRhmnyYJ2Tdg==
1803+
"@types/google.maps@^3.49.2":
1804+
version "3.49.2"
1805+
resolved "https://registry.yarnpkg.com/@types/google.maps/-/google.maps-3.49.2.tgz#9640491ec3aa96c9de1466894117ce81c02588df"
1806+
integrity sha512-ZO1qWciukqED9qcUNW7OaPXWnTlT+tO3WcYkmudZyQW2BqD7TlMFRrdqSCoqfwKhERCwBA5A/YZt/g5A3BqgLQ==
18071807

18081808
"@types/graceful-fs@^4.1.2":
18091809
version "4.1.5"
@@ -7428,7 +7428,7 @@ react-app-polyfill@^3.0.0:
74287428
regenerator-runtime "^0.13.9"
74297429
whatwg-fetch "^3.6.2"
74307430

7431-
react-cool-onclickoutside@^1.7.0:
7431+
react-cool-onclickoutside@latest:
74327432
version "1.7.0"
74337433
resolved "https://registry.yarnpkg.com/react-cool-onclickoutside/-/react-cool-onclickoutside-1.7.0.tgz#abc844e14852220fe15f81d7ef44976d15cd9980"
74347434
integrity sha512-HVZK2155Unee+enpoHKyYP2UdQK69thw90XAOUCjvJBcgRSgfRPgWWt/W1dYzoGp3+nleAa8SJxF1d4FMA4Qmw==
@@ -8877,10 +8877,10 @@ uri-js@^4.2.2:
88778877
dependencies:
88788878
punycode "^2.1.0"
88798879

8880-
use-places-autocomplete@^2.0.0:
8881-
version "2.0.0"
8882-
resolved "https://registry.yarnpkg.com/use-places-autocomplete/-/use-places-autocomplete-2.0.0.tgz#868454252f52f281b64d637f44283fde0cc06c84"
8883-
integrity sha512-MO1MBaaOW+tK8iatf9CPBbjwvtoa7lCNVamAkne9pTP6YcKmbQa/uLZa5nLqR5E8WulvLcC/R4Skuw1joVz45Q==
8880+
use-places-autocomplete@latest:
8881+
version "3.0.0"
8882+
resolved "https://registry.yarnpkg.com/use-places-autocomplete/-/use-places-autocomplete-3.0.0.tgz#1ef709e27212b4cc0d3db17b13039dc9a9cefd48"
8883+
integrity sha512-goow+G/crCRQ1WMVw6RMiBfH/7VQF38dF6ccS4YBzr49qEuYNN9PzaBEdUGvi5S4CMnXIqfT+zDLsy/u9kqy4Q==
88848884

88858885
util-deprecate@^1.0.1, util-deprecate@^1.0.2, util-deprecate@~1.0.1:
88868886
version "1.0.2"

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"@rollup/plugin-replace": "^3.0.1",
7777
"@testing-library/react": "^12.1.2",
7878
"@testing-library/react-hooks": "^7.0.2",
79-
"@types/googlemaps": "^3.43.3",
79+
"@types/google.maps": "^3.49.2",
8080
"@types/jest": "^27.4.0",
8181
"@types/lodash.debounce": "^4.0.6",
8282
"@types/react": "^17.0.38",

src/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ type GeoArgs = google.maps.GeocoderRequest;
44

55
type GeocodeResult = google.maps.GeocoderResult;
66

7-
type GeoReturn = Promise<GeocodeResult[]>;
7+
type GeoReturn = Promise<GeocodeResult[] | null>;
88

99
export const geocodeErr =
1010
"💡 use-places-autocomplete: Please provide an address when using getGeocode() with the componentRestrictions.";
@@ -48,7 +48,7 @@ export const getZipCode = (
4848

4949
type GetDetailsArgs = google.maps.places.PlaceDetailsRequest;
5050

51-
type DetailsResult = Promise<google.maps.places.PlaceResult | string>;
51+
type DetailsResult = Promise<google.maps.places.PlaceResult | null>;
5252

5353
export const getDetailsErr =
5454
"💡 use-places-autocomplete: Please provide a place Id when using getDetails() either as a string or as part of an Autocomplete Prediction.";

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1458,10 +1458,10 @@
14581458
"@types/minimatch" "*"
14591459
"@types/node" "*"
14601460

1461-
"@types/googlemaps@^3.43.3":
1462-
version "3.43.3"
1463-
resolved "https://registry.yarnpkg.com/@types/googlemaps/-/googlemaps-3.43.3.tgz#70cf962154a160fe78bcd69d6ccc296dd9175b1f"
1464-
integrity sha512-ZWNoz/O8MPEpiajvj7QiqCY8tTLFNqNZ/a+s+zTV58wFVNAvvqV4bdGfnsjTb5Cs4V6wEsLrX8XRhmnyYJ2Tdg==
1461+
"@types/google.maps@^3.49.2":
1462+
version "3.49.2"
1463+
resolved "https://registry.yarnpkg.com/@types/google.maps/-/google.maps-3.49.2.tgz#9640491ec3aa96c9de1466894117ce81c02588df"
1464+
integrity sha512-ZO1qWciukqED9qcUNW7OaPXWnTlT+tO3WcYkmudZyQW2BqD7TlMFRrdqSCoqfwKhERCwBA5A/YZt/g5A3BqgLQ==
14651465

14661466
"@types/graceful-fs@^4.1.2":
14671467
version "4.1.5"

0 commit comments

Comments
 (0)