Merge pull request #116 from emabrey/master

Closes: #115

Author: emabrey

.travis.yml

@@ -5,8 +5,12 @@ sudo: false
 language: java
 
 jdk:
+  - openjdk8
   - oraclejdk8
-  
+  - oraclejdk9
+#  - oraclejdk10
+#  - oraclejdk11
+
 #Cache downloaded Maven artifacts between builds
 cache:
   directories:

pom.xml

@@ -17,6 +17,9 @@
     <nbm.signing.keystorealias></nbm.signing.keystorealias>
     <nbm.signing.keystorepassword></nbm.signing.keystorepassword>
     <nbm.skip>false</nbm.skip>
+    
+    <!-- Set to a custom path of some local JDK to use it to execite nbm:run-ide -->
+    <nbm.jdkHome>${env.JAVA_HOME}</nbm.jdkHome>
   </properties>
 
   <repositories>
@@ -59,6 +62,12 @@
       <artifactId>org-netbeans-api-annotations-common</artifactId>
       <version>${netbeans.api.version}</version>
     </dependency>
+        
+    <dependency>
+      <groupId>org.netbeans.api</groupId>
+      <artifactId>org-netbeans-modules-java-platform</artifactId>
+      <version>${netbeans.api.version}</version>
+    </dependency>
 
     <!-- BaseDocument & Co. -->
     <dependency>
@@ -254,7 +263,7 @@
     <dependency>
       <groupId>org.netbeans.api</groupId>
       <artifactId>org-netbeans-modules-editor-util</artifactId>
-      <version>RELEASE82</version>
+      <version>${netbeans.api.version}</version>
     </dependency>
   </dependencies>
 
@@ -278,6 +287,8 @@
           <publicPackages>
             <publicPackage>com.welovecoding.netbeans.plugin.editorconfig</publicPackage>
           </publicPackages>
+          <additionalArguments>--jdkhome ${nbm.jdkHome}</additionalArguments>
+          <debugAdditionalArguments></debugAdditionalArguments>
         </configuration>
       </plugin>
       <plugin>
@@ -300,6 +311,7 @@
           </execution>
         </executions>
       </plugin>
+       
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-compiler-plugin</artifactId>
@@ -309,6 +321,7 @@
           <target>1.7</target>
           <showWarnings>true</showWarnings>
           <optimize>true</optimize>
+          <showDeprecation>true</showDeprecation>
         </configuration>
       </plugin>
       <plugin>

src/main/java/com/welovecoding/nbeditorconfig/listener/Installer.java

@@ -2,79 +2,105 @@
 
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+import javax.swing.Icon;
 import javax.swing.plaf.metal.MetalIconFactory;
+import org.netbeans.api.java.platform.JavaPlatform;
+import org.netbeans.api.java.platform.JavaPlatformManager;
+import org.netbeans.api.java.platform.Specification;
 import org.openide.DialogDisplayer;
 import org.openide.NotifyDescriptor;
 import org.openide.awt.NotificationDisplayer;
 import org.openide.modules.ModuleInstall;
+import org.openide.modules.SpecificationVersion;
 import org.openide.util.NbBundle;
 
 public class Installer extends ModuleInstall {
+  
+  /**
+   * Class Logger
+   */
+  private static final Logger INSTALLER_LOGGER = Logger.getLogger(Installer.class.getName());
 
-  private static final int MIN_JAVA_VERSION = 8;
+  /**
+   * A representation of the minimum required version of Java as a
+   * {@link SpecificationVersion} compatible "Dewey-decimal version".
+   */
+  private static final String MIN_JAVA_VERSION = "1.7.0";
 
   @Override
-  public void restored() {
-    if (detectOldJava()) {
-      final String title = NbBundle.getMessage(Installer.class, "wlc-nbeditorconfig-version-error-title");
-      final String message = NbBundle.getMessage(Installer.class, "wlc-nbeditorconfig-version-error-message");
-      final int messageType = NotifyDescriptor.ERROR_MESSAGE;
-
-      ActionListener actionListener = new ActionListener() {
-        @Override
-        public void actionPerformed(ActionEvent e) {
-          DialogDisplayer.getDefault().notify(new NotifyDescriptor.Message(message, messageType));
-        }
-      };
-      NotificationDisplayer.getDefault().notify(title, new MetalIconFactory.FileIcon16(), message, actionListener);
+  public void restored() {    
+    if (isJavaVersionIncompatiable()) {
+      registerIncompatabilityNotification();
     }
   }
 
-  private boolean detectOldJava() {
-    return JavaVersion.getMinor() < MIN_JAVA_VERSION;
-  }
+  /**
+   * Displays a notification in the default notification UI containing
+   * information on the plugin's incompatibility with the current IDE's version
+   * of the JVM
+   */
+  private static void registerIncompatabilityNotification() {
 
-  private static class JavaVersion {
+    //These are the title, message and icon displayed in the notification area and within popup if user interacts with notification
+    final String incompatTitle = NbBundle.getMessage(Installer.class, "wlc-nbeditorconfig-version-error-title");
+    final String incompatMessage = NbBundle.getMessage(Installer.class, "wlc-nbeditorconfig-version-error-message");
+    final Icon incompatIcon = new MetalIconFactory.FileIcon16();
+    
+    INSTALLER_LOGGER.log(Level.SEVERE, incompatMessage);
 
-    private JavaVersion() {
-    }
-
-    public int getMajor() {
-      try {
-        return Integer.parseInt(getMappedVersion()[0]);
-      } catch (Exception ex) {
-        return 0;
+    final ActionListener notificationInteractionListener = new ActionListener() {
+      @Override
+      public void actionPerformed(ActionEvent e) {
+        NotifyDescriptor.Message pluginIncompatiableMessage = new NotifyDescriptor.Message(incompatMessage, NotifyDescriptor.ERROR_MESSAGE);
+        DialogDisplayer.getDefault().notify(pluginIncompatiableMessage);
       }
-    }
+    };
 
-    public static int getMinor() {
-      try {
-        return Integer.parseInt(getMappedVersion()[1]);
-      } catch (Exception ex) {
-        return 0;
-      }
-    }
+    NotificationDisplayer.getDefault().notify(incompatTitle, incompatIcon, incompatMessage, notificationInteractionListener);
 
-    /**
-     * Example: Patch version is "0_31" in Java 1.8.0_31
-     *
-     * @return
-     */
-    public static String getPatch() {
-      try {
-        return getMappedVersion()[2];
-      } catch (Exception ex) {
-        return "";
-      }
-    }
+  }
 
-    private static String[] getMappedVersion() throws Exception {
-      String[] splittedVersion = System.getProperty("java.version").split("\\."); // NOI18N
-      if (splittedVersion.length >= 3) {
-        return splittedVersion;
-      } else {
-        throw new RuntimeException("Could not determine Java version");
-      }
-    }
+  /**
+   * Evaluates the compatibility of the current JVM running the IDE against
+   * {@link #MIN_JAVA_VERSION}.
+   *
+   * @return True if the JVM running the IDE is not compatible with this
+   * plugin.
+   */
+  private boolean isJavaVersionIncompatiable() {
+    SpecificationVersion javaVersion = getJavaPlatformVersion();
+    
+    INSTALLER_LOGGER.log(Level.FINE, "Found Java version: " + javaVersion);
+    INSTALLER_LOGGER.log(Level.FINE, "Expected Java version: " + MIN_JAVA_VERSION);
+    
+    return javaVersion.compareTo(getMinimumRequiredJavaVersion()) < 0;
+  }
+
+  /**
+   * Convenience/readability method for generating a
+   * {@link SpecificationVersion} containing the version information equivalent
+   * to {@link #MIN_JAVA_VERSION}.
+   *
+   * @return
+   */
+  private static SpecificationVersion getMinimumRequiredJavaVersion() {
+    return new SpecificationVersion(MIN_JAVA_VERSION);
+  }
+
+  /**
+   * Determines the version of the Java environment the IDE is running within
+   * utilizing {@link JavaPlatform}.
+   *
+   * @return A {@link SpecificationVersion} instance containing the version
+   * information of the IDE JVM using a "Dewey-decimal format".
+   */
+  private static SpecificationVersion getJavaPlatformVersion() {
+    JavaPlatformManager idePlatformManager = JavaPlatformManager.getDefault();
+    JavaPlatform idePlatform = idePlatformManager.getDefaultPlatform();
+    Specification idePlatformSpec = idePlatform.getSpecification();
+
+    return idePlatformSpec.getVersion();
   }
 }