Useless logical and bitwise operations

[j2cry]

Meaningless number operations are prohibited by WPS345.
But meaningless logical operations are not handled

# not noticed
myvar = True or False
myvar = True and False
myvar = call() and False
myvar = call() and not True
myvar = call() or False

This may also be relevant for some bitwise operations

# noticed by WPS345
myvar = 1 | False
myvar = 1 | 0
myvar = 1 & 0

# not noticed
myvar = 1 & True
myvar = 1 | True
myvar = 5 | 5
myvar = 452 & 452

Should we deal with this?

[sobolevn]

Yes, sure!

ruff detects some of these issues:

SIM222 Use `True` instead of `True or ...`
 --> ex.py:2:9
  |
1 | # not noticed
2 | myvar = True or False
  |         ^^^^^^^^^^^^^
3 | myvar = True and False
4 | myvar = call() and False
  |
help: Replace with `True`

SIM223 Use `False` instead of `... and False`
 --> ex.py:3:9
  |
1 | # not noticed
2 | myvar = True or False
3 | myvar = True and False
  |         ^^^^^^^^^^^^^^
4 | myvar = call() and False
5 | myvar = call() and not True

Please, send a PR for each of the proposed ideas :)
Several small PRs will be easier to review.

[j2cry]

My ruff didn't catch anything. I tried with different settings, but without success :(

Should it all be covered by WPS345? Or logical operations must have their own ASTViolation?

[sobolevn]

Let's start with bitwise ones first :)
They can use existing useless operation code WPS345

[j2cry]

@sobolevn I need your advice.
I suppose that any math/bool operations with only constants should be prohibited, is it correct?

useless = 18 + 4
useless = 17 - 23
useless = 3 * 1.25
useless = 1 / 1.1
useless = 31 // 7
useless = -1.7 % 0.5
useless = 0.4 ** 1
useless = 4 << 2
useless = 4 >> 2
useless = -7 | 3
useless = 6 & -2
useless = 3 ^ 7

Or is any of this quite common?

[sobolevn]

Nope :)

Because sometimes math is your business logic.
It would make you code less readable in many cases.