Skip to content

Commit 2f93dd2

Browse files
author
Ilanji Rajamanickam
committed
Added new method to get keyfile
1 parent 6025282 commit 2f93dd2

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ project.ext {
1717
avroVersion = '1.8.1'
1818
debeziumVersion = '0.6.1'
1919
googleCloudVersion = '1.79.0'
20-
googleAuthVersion = '0.10.0'
20+
googleAuthVersion = '0.9.0'
2121
googleCloudGsonVersion = '2.8.5'
2222
ioConfluentVersion = '5.3.1'
2323
junitVersion = '4.12'

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/BigQuerySinkConnector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ private BigQuery getBigQuery() {
9191
return testBigQuery;
9292
}
9393
String projectName = config.getString(config.PROJECT_CONFIG);
94-
String key = config.getString(config.KEYFILE_CONFIG);
94+
String key = config.getKeyFile();
9595
String keySource = config.getString(config.KEY_SOURCE_CONFIG);
9696
return new BigQueryHelper().setKeySource(keySource).connect(projectName, key);
9797
}

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/BigQuerySinkTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ private BigQuery getBigQuery() {
262262
return testBigQuery;
263263
}
264264
String projectName = config.getString(config.PROJECT_CONFIG);
265-
String keyFile = config.getString(config.KEYFILE_CONFIG);
265+
String keyFile = config.getKeyFile();
266266
String keySource = config.getString(config.KEY_SOURCE_CONFIG);
267267
return new BigQueryHelper().setKeySource(keySource).connect(projectName, keyFile);
268268
}
@@ -299,7 +299,7 @@ private Storage getGcs() {
299299
return testGcs;
300300
}
301301
String projectName = config.getString(config.PROJECT_CONFIG);
302-
String key = config.getString(config.KEYFILE_CONFIG);
302+
String key = config.getKeyFile();
303303
String keySource = config.getString(config.KEY_SOURCE_CONFIG);
304304
return new GCSBuilder(projectName).setKey(key).setKeySource(keySource).build();
305305

kcbq-connector/src/main/java/com/wepay/kafka/connect/bigquery/config/BigQuerySinkConfig.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,13 @@ protected static Map.Entry<String, String> parseMapping(String mapping, String n
406406
}
407407
}
408408

409+
/**
410+
* Returns the keyfile
411+
*/
412+
public String getKeyFile() {
413+
return getPassword(KEYFILE_CONFIG).value();
414+
}
415+
409416
/**
410417
* Parses a config map, which must be provided as a list of Strings of the form
411418
* '&lt;key&gt;=&lt;value&gt;' into a Map. Locates that list, splits its key and value pairs, and

kcbq-connector/src/test/java/com/wepay/kafka/connect/bigquery/SinkPropertiesFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void testProperties(BigQuerySinkConfig config) {
6363
config.getList(config.TOPICS_TO_TABLES_CONFIG);
6464
config.getList(config.DATASETS_CONFIG);
6565

66-
config.getPassword(config.KEYFILE_CONFIG);
66+
config.getKeyFile();
6767
config.getString(config.PROJECT_CONFIG);
6868

6969
config.getBoolean(config.SANITIZE_TOPICS_CONFIG);

0 commit comments

Comments
 (0)