Skip to content
This repository was archived by the owner on Nov 20, 2025. It is now read-only.

Commit 2c3d9d0

Browse files
author
Mischa Braam
committed
Backwards compatbility for running commands
1 parent 50f072c commit 2c3d9d0

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

CHANGELOG.md

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,23 @@ All notable changes to valet-plus will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
## [Unreleased](https://github.com/weprovide/valet-plus/compare/2.1.0...2.x)
7+
## [Unreleased](https://github.com/weprovide/valet-plus/compare/2.2.1...2.x)
8+
- [#587] Minimum version of symfony/process causes fatal error
9+
- [#549] Fix xdebug veriosn 2.9.8 for PHP 7.x
10+
- Start highest installed major of Elasticsearch on valet start
11+
- Add libyaml as brew devtool
12+
- Use PHP 7.2 as default version
13+
14+
## [2.2.1](https://github.com/weprovide/valet-plus/compare/2.2.0...2.2.1)
15+
- Fix missing dependencies of sebastian/version
16+
17+
## [2.2.0](https://github.com/weprovide/valet-plus/compare/2.1.0...2.2.0)
18+
- [#517] Nginx config changes for fastcgi_buffers
19+
- [#554] Fix for Brew 2.7.0: brew list without commands
820
- [#551] Replace hardcoded Elasticsearch versions by fetching from Brew
921
- [#546] Add support for PHP 8.0
22+
- [#583] Add support for ioncube on PHP 7.4
23+
- Add --build-from-source when installing PHP
1024
- Use PHP 7.2 as default version
1125

1226
## [2.1.0](https://github.com/weprovide/valet-plus/compare/2.0.0...2.1.0)

cli/Valet/CommandLine.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,12 @@ public function runCommand($command, callable $onError = null)
7575
$onError = $onError ?: function () {
7676
};
7777

78-
$process = Process::fromShellCommandline($command);
78+
$process = null;
79+
if (is_callable(Process::class, 'fromShellCommandline')) {
80+
$process = Process::fromShellCommandline($command);
81+
} else {
82+
$process = new Process($command);
83+
}
7984

8085
$processOutput = '';
8186
$process->setTimeout(null)->run(function ($type, $line) use (&$processOutput) {

0 commit comments

Comments
 (0)