Skip to content

Commit 5e04e7e

Browse files
authored
Merge pull request #352 from werf/fix/no-failure-message-if-generic-tracker-conditions-failed
fix: no failure message if generic tracker conditions failed
2 parents 285ccc5 + b84b40e commit 5e04e7e

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

pkg/tracker/generic/resource_status.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,19 @@ func NewResourceStatus(object *unstructured.Unstructured) (*ResourceStatus, erro
2424
return nil, fmt.Errorf("error getting resource status indicator: %w", err)
2525
}
2626

27+
isFailed := resourceStatusIndicator != nil && resourceStatusIndicator.IsFailed()
28+
29+
var failureReason string
30+
if isFailed {
31+
failureReason = "Resource status field value matched failed condition."
32+
}
33+
2734
return &ResourceStatus{
2835
Indicator: resourceStatusIndicator,
2936
isReady: resourceStatusIndicator == nil || (resourceStatusIndicator != nil && resourceStatusIndicator.IsReady()),
30-
isFailed: resourceStatusIndicator != nil && resourceStatusIndicator.IsFailed(),
37+
isFailed: isFailed,
3138
humanConditionPath: humanJSONPath,
39+
failureReason: failureReason,
3240
}, nil
3341
}
3442

0 commit comments

Comments
 (0)