chore: consistent naming of TODOs for major

Signed-off-by: Ilya Lesikov <ilya@lesikov.com>

Author: ilya-lesikov

pkg/tracker/daemonset/tracker.go

@@ -26,10 +26,9 @@ import (
 )
 
 type PodAddedReport struct {
-	// FIXME !!! DaemonSet is not like Deployment.
-	// FIXME !!! DaemonSet is not related to ReplicaSet.
-	// FIXME !!! Pods of DaemonSet have owner reference directly to ReplicaSet.
-	// FIXME !!! Delete all ReplicaSet-related data.
+	// FIXME: DaemonSet is not like Deployment. DaemonSet is not related to
+	// ReplicaSet. Pods of DaemonSet have owner reference directly to ReplicaSet.
+	// Delete all ReplicaSet-related data.
 	Pod             replicaset.ReplicaSetPod
 	DaemonSetStatus DaemonSetStatus
 }

pkg/tracker/statefulset/status.go

@@ -41,7 +41,6 @@ func NewStatefulSetStatus(object *appsv1.StatefulSet, statusGeneration uint64, i
 		WarningMessages:   warningMessages,
 	}
 
-	// TODO: share common code from deploy, ds and sts
 processingPodsStatuses:
 	for k, v := range podsStatuses {
 		res.Pods[k] = v

pkg/trackers/rollout/multitrack/multitrack.go

@@ -37,7 +37,7 @@ type FailMode string
 const (
 	IgnoreAndContinueDeployProcess    FailMode = "IgnoreAndContinueDeployProcess"
 	FailWholeDeployProcessImmediately FailMode = "FailWholeDeployProcessImmediately"
-	// TODO(v2): get rid. Is an equivalent to FailWholeDeployProcessImmediately at the moment.
+	// TODO(major): get rid. Is an equivalent to FailWholeDeployProcessImmediately at the moment.
 	LegacyHopeUntilEndOfDeployProcess FailMode = "HopeUntilEndOfDeployProcess"
 )
 
@@ -77,7 +77,6 @@ type MultitrackSpec struct {
 	SkipLogs                  bool
 	SkipLogsForContainers     []string
 	ShowLogsOnlyForContainers []string
-	// ShowLogsUntil             DeployCondition TODO
 
 	ShowServiceMessages bool
 }

pkg/utils/deployment_utils.go

@@ -203,8 +203,6 @@ func FindOldReplicaSets(deployment *appsv1.Deployment, rsList []*appsv1.ReplicaS
 // because only the controller itself should do that.
 // However, it does filter out anything whose ControllerRef doesn't match.
 func ListReplicaSets(deployment *appsv1.Deployment, getRSList rsListFunc) ([]*appsv1.ReplicaSet, error) {
-	// TODO: Right now we list replica sets by their labels. We should list them by selector, i.e. the replica set's selector
-	//       should be a superset of the deployment's selector, see https://github.com/kubernetes/kubernetes/issues/19830.
 	namespace := deployment.Namespace
 	selector, err := metav1.LabelSelectorAsSelector(deployment.Spec.Selector)
 	if err != nil {

pkg/utils/ref.go

@@ -35,7 +35,6 @@ func GetReference(obj runtime.Object) (*corev1.ObjectReference, error) {
 	// if we are building an object reference to something not yet persisted, we should fallback to scheme
 	kind := gvk.Kind
 	if len(kind) == 0 {
-		// TODO: this is wrong
 		gvks, _, err := scheme.ObjectKinds(obj)
 		if err != nil {
 			return nil, err