File tree Expand file tree Collapse file tree 1 file changed +13
-0
lines changed
Expand file tree Collapse file tree 1 file changed +13
-0
lines changed Original file line number Diff line number Diff line change @@ -27,6 +27,19 @@ Key assumptions reviewers MUST account for:
2727 a localhost-only service. Do not flag missing MaxBytesReader or
2828 similar unless the endpoint is exposed to untrusted networks.
2929
30+ 6. SESSION DATA DISPLAY: The tool reads session files from the
31+ user's own disk and displays their contents (including tool call
32+ arguments, bash commands, prompts, file paths). This is the
33+ tool's core purpose. Storing and rendering input_json, commands,
34+ or other session content is NOT a credential exposure risk —
35+ the user already has full access to these files. Do not flag
36+ tool argument storage or display as sensitive data exposure.
37+
38+ 7. SCHEMA VERIFICATION: The tool_calls table has an explicit
39+ `id INTEGER PRIMARY KEY` column (schema.sql). Do not flag
40+ ORDER BY id or references to tool_calls.id as missing-column
41+ errors without verifying the actual schema.
42+
3043Do NOT flag issues that only apply to public-facing, multi-tenant,
3144or network-exposed services. Focus on bugs, logic errors, data
3245corruption risks, and code quality issues.
You can’t perform that action at this time.
0 commit comments