fix: remove legacy migration from .agent-session-viewer

Delete MigrateFromLegacy and all associated tests/helpers.
The legacy directory is no longer supported.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: wesm

cmd/agentsview/main.go

@@ -154,12 +154,6 @@ func mustLoadConfig(args []string) config.Config {
 		log.Fatalf("parsing flags: %v", err)
 	}
 
-	dataDir, err := config.ResolveDataDir()
-	if err != nil {
-		log.Fatalf("resolving data dir: %v", err)
-	}
-	config.MigrateFromLegacy(dataDir)
-
 	cfg, err := config.Load(fs)
 	if err != nil {
 		log.Fatalf("loading config: %v", err)

cmd/agentsview/prune.go

@@ -236,12 +236,6 @@ func runPrune(args []string) {
 		os.Exit(1)
 	}
 
-	dataDir, err := config.ResolveDataDir()
-	if err != nil {
-		log.Fatalf("resolving data dir: %v", err)
-	}
-	config.MigrateFromLegacy(dataDir)
-
 	appCfg, err := config.LoadMinimal()
 	if err != nil {
 		log.Fatalf("loading config: %v", err)

internal/config/config.go

@@ -62,8 +62,7 @@ func Load(fs *flag.FlagSet) (Config, error) {
 
 // LoadMinimal builds a Config from defaults, env, and config file,
 // without parsing CLI flags. Use this for subcommands that manage
-// their own flag sets. Call MigrateFromLegacy before this if
-// legacy data migration is needed.
+// their own flag sets.
 func LoadMinimal() (Config, error) {
 	cfg, err := Default()
 	if err != nil {

internal/config/config_test.go

@@ -24,58 +24,6 @@ func skipIfNotUnix(t *testing.T) {
 	}
 }
 
-const (
-	legacyDirName = ".agent-session-viewer"
-	newDirName    = ".agentsview"
-)
-
-// setupLegacyEnv creates a temp directory with a populated legacy
-// data dir and returns (tmp, newDir). Files are written into the
-// legacy directory with config.json getting 0o600 permissions and
-// all other files getting 0o644.
-func setupLegacyEnv(
-	t *testing.T, files map[string]string,
-) (string, string) {
-	t.Helper()
-	tmp := t.TempDir()
-	legacyDir := filepath.Join(tmp, legacyDirName)
-	newDir := filepath.Join(tmp, newDirName)
-
-	if err := os.MkdirAll(legacyDir, 0o755); err != nil {
-		t.Fatalf("create legacy dir: %v", err)
-	}
-
-	for name, content := range files {
-		perm := os.FileMode(0o644)
-		if name == "config.json" {
-			perm = 0o600
-		}
-		path := filepath.Join(legacyDir, name)
-		if err := os.WriteFile(
-			path, []byte(content), perm,
-		); err != nil {
-			t.Fatalf("write %s: %v", name, err)
-		}
-	}
-	return tmp, newDir
-}
-
-func assertFileContent(
-	t *testing.T, path, expected string,
-) {
-	t.Helper()
-	data, err := os.ReadFile(path)
-	if err != nil {
-		t.Fatalf("read %s: %v", filepath.Base(path), err)
-	}
-	if string(data) != expected {
-		t.Errorf(
-			"%s content = %q, want %q",
-			filepath.Base(path), data, expected,
-		)
-	}
-}
-
 func writeConfig(t *testing.T, dir string, data any) {
 	t.Helper()
 	b, err := json.Marshal(data)
@@ -135,25 +83,6 @@ func configWithTmpDir(t *testing.T) (Config, string) {
 	return Config{DataDir: dir}, dir
 }
 
-// assertFilePerm checks that the file at path has permission bits
-// matching the given mask and expected value.
-func assertFilePerm(
-	t *testing.T, path string,
-	mask, want os.FileMode,
-) {
-	t.Helper()
-	info, err := os.Stat(path)
-	if err != nil {
-		t.Fatalf("stat %s: %v", filepath.Base(path), err)
-	}
-	if got := info.Mode().Perm() & mask; got != want {
-		t.Errorf(
-			"%s perm & %o = %o, want %o",
-			filepath.Base(path), mask, got, want,
-		)
-	}
-}
-
 func loadConfigFromFlags(t *testing.T, args ...string) (Config, error) {
 	t.Helper()
 	fs := flag.NewFlagSet("test", flag.ContinueOnError)
@@ -164,123 +93,6 @@ func loadConfigFromFlags(t *testing.T, args ...string) (Config, error) {
 	return Load(fs)
 }
 
-func TestMigrateFromLegacy(t *testing.T) {
-	tests := []struct {
-		name         string
-		legacyFiles  map[string]string
-		preCreateNew bool
-		wantFiles    map[string]string // Content to assert in new dir
-		wantMissing  []string          // Files that should NOT exist
-	}{
-		{
-			name: "CopiesGoDBAndConfig",
-			legacyFiles: map[string]string{
-				"sessions-go.db": "go-db-content",
-				"config.json":    `{"github_token": "secret"}`,
-			},
-			wantFiles: map[string]string{
-				"sessions.db": "go-db-content",
-				"config.json": `{"github_token": "secret"}`,
-			},
-		},
-		{
-			name: "CopiesGoDBOnly",
-			legacyFiles: map[string]string{
-				"sessions-go.db": "just-db",
-			},
-			wantFiles: map[string]string{
-				"sessions.db": "just-db",
-			},
-			wantMissing: []string{"config.json"},
-		},
-		{
-			name: "IgnoresPythonDB",
-			legacyFiles: map[string]string{
-				"sessions.db": "python-db",
-				"config.json": `{"github_token":"tok"}`,
-			},
-			wantFiles: map[string]string{
-				"config.json": `{"github_token":"tok"}`,
-			},
-			wantMissing: []string{"sessions.db"},
-		},
-		{
-			name: "SkipsIfNewDirExists",
-			legacyFiles: map[string]string{
-				"sessions.db": "db",
-			},
-			preCreateNew: true,
-			wantMissing:  []string{"sessions.db"},
-		},
-		{
-			name:        "SkipsIfNoLegacyDir",
-			legacyFiles: nil,
-			wantMissing: []string{"."},
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			var tmp, newDir string
-			if tt.legacyFiles != nil {
-				tmp, newDir = setupLegacyEnv(t, tt.legacyFiles)
-			} else {
-				tmp = t.TempDir()
-				newDir = filepath.Join(tmp, newDirName)
-			}
-
-			if tt.preCreateNew {
-				if err := os.MkdirAll(newDir, 0o700); err != nil {
-					t.Fatal(err)
-				}
-			}
-
-			t.Setenv("HOME", tmp)
-			MigrateFromLegacy(newDir)
-
-			if tt.legacyFiles == nil {
-				if _, err := os.Stat(newDir); err == nil {
-					t.Error("new dir should not be created without legacy dir")
-				}
-				return
-			}
-
-			for path, content := range tt.wantFiles {
-				assertFileContent(t, filepath.Join(newDir, path), content)
-			}
-
-			for _, path := range tt.wantMissing {
-				if _, err := os.Stat(filepath.Join(newDir, path)); err == nil {
-					t.Errorf("file %s should not exist", path)
-				}
-			}
-		})
-	}
-}
-
-func TestMigrateFromLegacy_FilePermissions(t *testing.T) {
-	if runtime.GOOS == "windows" {
-		t.Skip("file permission checks not reliable on Windows")
-	}
-
-	tmp, newDir := setupLegacyEnv(t, map[string]string{
-		"sessions-go.db": "db",
-		"config.json":    `{"github_token":"x"}`,
-	})
-
-	t.Setenv("HOME", tmp)
-	MigrateFromLegacy(newDir)
-
-	// Data dir must not be group/other accessible
-	assertFilePerm(t, newDir, 0o077, 0)
-
-	// config.json must not be group/other readable
-	assertFilePerm(t, filepath.Join(newDir, "config.json"), 0o077, 0)
-
-	// sessions.db should be owner-accessible
-	assertFilePerm(t, filepath.Join(newDir, "sessions.db"), 0o400, 0o400)
-}
-
 func TestLoadEnv_OverridesDataDir(t *testing.T) {
 	custom, _ := setupConfigDir(t)
 
@@ -434,37 +246,3 @@ func TestResolveDataDir_DefaultAndEnvOverride(t *testing.T) {
 	}
 }
 
-// TestMigrateThenLoad_GithubTokenAvailable verifies that the
-// startup sequence (resolve data dir, migrate, load) makes
-// legacy github_token immediately available without a second
-// load.
-func TestMigrateThenLoad_GithubTokenAvailable(t *testing.T) {
-	cfgJSON, _ := json.Marshal(map[string]string{
-		"github_token": "legacy-secret",
-	})
-	tmp, newDir := setupLegacyEnv(t, map[string]string{
-		"config.json": string(cfgJSON),
-	})
-
-	t.Setenv("HOME", tmp)
-	t.Setenv("AGENT_VIEWER_DATA_DIR", newDir)
-
-	// Simulate startup: resolve, migrate, then load
-	dataDir, err := ResolveDataDir()
-	if err != nil {
-		t.Fatal(err)
-	}
-	MigrateFromLegacy(dataDir)
-
-	cfg, err := LoadMinimal()
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	if cfg.GithubToken != "legacy-secret" {
-		t.Errorf(
-			"GithubToken = %q, want %q",
-			cfg.GithubToken, "legacy-secret",
-		)
-	}
-}