Skip to content

Commit 1024f34

Browse files
committed
[CHORE]#289 : 쪽지 / 기능 내 이벤트 제거
1 parent e13a469 commit 1024f34

File tree

3 files changed

+1
-57
lines changed

3 files changed

+1
-57
lines changed

feature/message/src/main/kotlin/com/bff/wespot/message/viewmodel/SendViewModel.kt

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ package com.bff.wespot.message.viewmodel
22

33
import androidx.lifecycle.viewModelScope
44
import androidx.paging.cachedIn
5-
import com.bff.wespot.analytic.AnalyticsEvent
6-
import com.bff.wespot.analytic.AnalyticsHelper
75
import com.bff.wespot.common.extension.onNetworkFailure
86
import com.bff.wespot.designsystem.component.indicator.WSToastType
97
import com.bff.wespot.domain.repository.BasePagingRepository
@@ -44,9 +42,6 @@ import org.orbitmvi.orbit.syntax.simple.postSideEffect
4442
import org.orbitmvi.orbit.syntax.simple.reduce
4543
import org.orbitmvi.orbit.viewmodel.container
4644
import timber.log.Timber
47-
import java.time.LocalDateTime
48-
import java.time.ZoneId
49-
import java.time.format.DateTimeFormatter
5045
import javax.inject.Inject
5146

5247
@HiltViewModel
@@ -56,7 +51,6 @@ class SendViewModel @Inject constructor(
5651
private val commonRepository: CommonRepository,
5752
private val userListRepository: BasePagingRepository<User, Paging<User>>,
5853
private val checkProfanityUseCase: CheckProfanityUseCase,
59-
private val analyticsHelper: AnalyticsHelper,
6054
) : BaseViewModel(), ContainerHost<MessageSendUiState, MessageSendSideEffect> {
6155
override val container = container<MessageSendUiState, MessageSendSideEffect>(MessageSendUiState())
6256

@@ -435,7 +429,6 @@ class SendViewModel @Inject constructor(
435429
anonymousProfileName = state.senderProfile.name,
436430
),
437431
).onSuccess {
438-
trackMessageSendEvent()
439432
reduce { state.copy(isLoading = false) }
440433
postSideEffect(SendSideEffect.ShowToast(R.string.message_send_success))
441434
postSideEffect(SendSideEffect.NavigateToMessage)
@@ -455,21 +448,6 @@ class SendViewModel @Inject constructor(
455448
uploadResult.getOrThrow()
456449
}
457450

458-
private fun trackMessageSendEvent() = intent {
459-
val formatter = DateTimeFormatter.ISO_LOCAL_DATE_TIME
460-
val sendTime = LocalDateTime.now(ZoneId.of("Asia/Seoul")).format(formatter)
461-
462-
analyticsHelper.logEvent(
463-
event = AnalyticsEvent(
464-
type = "message_send",
465-
extras = listOf(
466-
AnalyticsEvent.Param("userId", state.profile.id.toString()),
467-
AnalyticsEvent.Param("time", sendTime),
468-
),
469-
),
470-
)
471-
}
472-
473451
fun clearUiState() = intent {
474452
reduce {
475453
MessageSendUiState()

feature/vote/src/main/java/com/bff/wespot/vote/screen/IndividualVoteScreen.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import androidx.compose.ui.res.stringResource
3030
import androidx.compose.ui.unit.dp
3131
import androidx.hilt.navigation.compose.hiltViewModel
3232
import androidx.lifecycle.compose.collectAsStateWithLifecycle
33-
import com.bff.wespot.analytic.LocalAnalyticsHelper
34-
import com.bff.wespot.analytic.TrackScreenViewEvent
3533
import com.bff.wespot.designsystem.component.button.WSButton
3634
import com.bff.wespot.designsystem.component.header.WSTopBar
3735
import com.bff.wespot.designsystem.component.indicator.WSToastType
@@ -75,8 +73,6 @@ fun IndividualVoteScreen(
7573
val individual by viewModel.individual.collectAsStateWithLifecycle()
7674
val context = LocalContext.current
7775

78-
val analyticsHelper = LocalAnalyticsHelper.current
79-
8076
val networkState by viewModel.networkState.collectAsStateWithLifecycle()
8177

8278
var showToast by remember { mutableStateOf(false) }
@@ -205,6 +201,4 @@ fun IndividualVoteScreen(
205201
}
206202

207203
NetworkDialog(context = context, networkState = networkState)
208-
209-
TrackScreenViewEvent(screenName = "receive_vote_screen")
210204
}

feature/vote/src/main/java/com/bff/wespot/vote/screen/VotingScreen.kt

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,6 @@ import androidx.compose.ui.unit.dp
3535
import androidx.lifecycle.compose.collectAsStateWithLifecycle
3636
import coil.compose.AsyncImage
3737
import coil.request.ImageRequest
38-
import com.bff.wespot.analytic.AnalyticsEvent
39-
import com.bff.wespot.analytic.AnalyticsEvent.Param
40-
import com.bff.wespot.analytic.AnalyticsHelper
41-
import com.bff.wespot.analytic.LocalAnalyticsHelper
42-
import com.bff.wespot.analytic.TrackScreenViewEvent
4338
import com.bff.wespot.designsystem.component.button.WSButton
4439
import com.bff.wespot.designsystem.component.button.WSOutlineButton
4540
import com.bff.wespot.designsystem.component.button.WSOutlineButtonType
@@ -83,20 +78,10 @@ fun VotingScreen(
8378
) {
8479
val state by viewModel.collectAsState()
8580
val action = viewModel::onAction
86-
val analyticsHelper = LocalAnalyticsHelper.current
8781
val networkState by viewModel.networkState.collectAsStateWithLifecycle()
8882

8983
val context = LocalContext.current
9084

91-
analyticsHelper.logEvent(
92-
AnalyticsEvent(
93-
type = "vote_screen_view",
94-
extras = listOf(
95-
Param("screen_name", "vote_screen"),
96-
),
97-
),
98-
)
99-
10085
var submitButton by remember { mutableStateOf(false) }
10186

10287
var toast by remember {
@@ -169,7 +154,7 @@ fun VotingScreen(
169154
if (state.loading && showGuideScreen && !restricted.restricted) {
170155
return@Scaffold
171156
} else if (showGuideScreen) {
172-
VotingGuideScreen(it, navigator, state, analyticsHelper)
157+
VotingGuideScreen(it, navigator, state)
173158
} else {
174159
VotingProgressScreen(
175160
state = state,
@@ -353,7 +338,6 @@ private fun VotingGuideScreen(
353338
paddingValues: PaddingValues,
354339
navigator: Navigator,
355340
state: VotingUiState,
356-
analyticsHelper: AnalyticsHelper,
357341
) {
358342
val context = LocalContext.current
359343

@@ -382,22 +366,10 @@ private fun VotingGuideScreen(
382366
}
383367
Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.BottomCenter) {
384368
WSButton(onClick = {
385-
analyticsHelper.logEvent(
386-
AnalyticsEvent(
387-
type = "empty_vote_invite_friend",
388-
extras = listOf(
389-
Param("screen_name", "vote_empty_screen"),
390-
Param("invite_clicked", "true"),
391-
),
392-
),
393-
)
394-
395369
val message = context.getString(com.bff.wespot.designsystem.R.string.invite_message)
396370
navigator.navigateToSharing(context, message + state.playStoreLink)
397371
}, text = stringResource(R.string.invite_friend_vote)) {
398372
it.invoke()
399373
}
400374
}
401-
402-
TrackScreenViewEvent(screenName = "vote_empty_screen")
403375
}

0 commit comments

Comments
 (0)