Skip to content

Commit 155b0b4

Browse files
authored
Merge pull request #297 from wespot-bff/feature/jaino/#296
#296 : 바텀 네비게이션 MY 탭 아이콘 변경 및 커뮤니티 알림 설정 구현 + 링크 수정
2 parents d4ad3ca + 0842e93 commit 155b0b4

File tree

18 files changed

+61
-43
lines changed

18 files changed

+61
-43
lines changed

app/src/main/kotlin/com/bff/wespot/main/component/BottomNavigationTab.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import androidx.compose.foundation.layout.Column
88
import androidx.compose.foundation.layout.Row
99
import androidx.compose.foundation.layout.RowScope
1010
import androidx.compose.foundation.layout.fillMaxWidth
11-
import androidx.compose.foundation.layout.size
11+
import androidx.compose.foundation.layout.height
12+
import androidx.compose.foundation.layout.padding
1213
import androidx.compose.material3.Icon
1314
import androidx.compose.material3.NavigationBar
1415
import androidx.compose.material3.Text
@@ -39,7 +40,7 @@ internal fun BottomNavigationTab(
3940
) {
4041
NavigationBar(
4142
containerColor = WeSpotThemeManager.colors.naviColor,
42-
modifier = modifier,
43+
modifier = modifier.height(69.dp),
4344
) {
4445
Row(
4546
modifier = Modifier.fillMaxWidth(),
@@ -94,7 +95,6 @@ private fun RowScope.TabItem(
9495

9596
Box(
9697
modifier = Modifier
97-
.size(80.dp)
9898
.weight(1f)
9999
.clickableSingle {
100100
hapticEngine?.let {
@@ -106,6 +106,7 @@ private fun RowScope.TabItem(
106106
contentAlignment = Alignment.Center,
107107
) {
108108
Column(
109+
modifier = Modifier.padding(top = 10.dp, bottom = 18.dp),
109110
horizontalAlignment = Alignment.CenterHorizontally,
110111
) {
111112
Icon(
@@ -119,7 +120,7 @@ private fun RowScope.TabItem(
119120

120121
Text(
121122
text = title,
122-
style = StaticTypeScale.Default.body9,
123+
style = StaticTypeScale.Default.body10,
123124
color = if (selected) {
124125
WeSpotThemeManager.colors.abledIconColor
125126
} else {

core/model/src/main/kotlin/com/bff/wespot/model/message/response/MessageProfile.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,4 @@ data class MessageProfile(
77
val schoolName: String = "",
88
val grade: Int = -1,
99
val classNumber: Int = -1,
10-
) {
11-
fun toDescription(): String = if (isAnonymous) {
12-
name
13-
} else {
14-
"$schoolName ${grade}학년 ${classNumber}$name"
15-
}
16-
}
10+
)
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
package com.bff.wespot.model.user.response
22

33
data class NotificationSetting(
4+
val isEnablePostNotification: Boolean,
45
val isEnableVoteNotification: Boolean,
56
val isEnableMessageNotification: Boolean,
67
val isEnableMarketingNotification: Boolean,
78
) {
8-
constructor() : this(false, false, false)
9+
constructor() : this(false, false, false, false)
910
}

data-remote/src/main/kotlin/com/bff/wespot/data/remote/model/message/response/MessageRoomDto.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ data class MessageRoomDto(
1717
name = name,
1818
thumbnail = thumbnail,
1919
isBookmarked = isBookmarked,
20+
isReceiverAnonymous = isReceiverAnonymous,
2021
messageDetails = messageDetails.map { it.toDomain() },
2122
)
2223
}

data-remote/src/main/kotlin/com/bff/wespot/data/remote/model/user/response/NotificationSettingDto.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@ import kotlinx.serialization.Serializable
55

66
@Serializable
77
data class NotificationSettingDto (
8+
val isEnablePostNotification: Boolean,
89
val isEnableVoteNotification: Boolean,
910
val isEnableMessageNotification: Boolean,
1011
val isEnableMarketingNotification: Boolean,
1112
) {
1213
fun toNotificationSetting(): NotificationSetting = NotificationSetting(
14+
isEnablePostNotification = isEnablePostNotification,
1315
isEnableVoteNotification = isEnableVoteNotification,
1416
isEnableMessageNotification = isEnableMessageNotification,
1517
isEnableMarketingNotification = isEnableMarketingNotification,

data/src/main/kotlin/com/bff/wespot/data/mapper/user/UserMapper.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import com.bff.wespot.data.remote.model.user.response.ProfileCharacterDto
66
import com.bff.wespot.model.user.response.ProfileCharacter
77

88
internal fun NotificationSetting.toNotificationSettingDto() = NotificationSettingDto(
9+
isEnablePostNotification = isEnablePostNotification,
910
isEnableVoteNotification = isEnableVoteNotification,
1011
isEnableMessageNotification = isEnableMessageNotification,
1112
isEnableMarketingNotification = isEnableMarketingNotification,

designsystem/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<string name="letter_sender">From.</string>
2828
<string name="letter_opened">읽음</string>
2929
<string name="letter_image">Letter Image</string>
30-
<string name="entire">전체</string>
30+
<string name="entire">MY</string>
3131
<string name="invalid_message">invalid_message</string>
3232
<string name="has_profanity">비속어가 포함되어 있어요</string>
3333
<string name="close">닫기</string>

domain/src/main/kotlin/com/bff/wespot/domain/util/RemoteConfigKey.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ object RemoteConfigKey {
1313
const val RESEARCH_PARTICIPATION_GOOGLE_FORM_URL = "RESEARCH_PARTICIPATION_GOOGLE_FORM_URL"
1414
const val WESPOT_MAKERS_URL = "WESPOT_MAKERS_URL"
1515
const val PROFILE_CHANGE_GOOGLE_FORM_URL = "PROFILE_CHANGE_GOOGLE_FORM_URL"
16+
const val COMMUNITY_POLICY_URL = "COMMUNITY_GUIDELINES_URL"
1617
const val PRIVACY_POLICY_URL = "PRIVACY_POLICY_URL"
1718
const val PLAY_STORE_URL = "PLAY_STORE_URL"
1819
const val TERMS_OF_SERVICE_URL = "TERMS_OF_SERVICE_URL"

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/CompleteScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package com.bff.wespot.auth.screen
22

3-
import android.app.Activity
43
import androidx.activity.compose.BackHandler
4+
import androidx.activity.compose.LocalActivity
55
import androidx.compose.foundation.Image
66
import androidx.compose.foundation.layout.Box
77
import androidx.compose.foundation.layout.Column
@@ -50,7 +50,7 @@ fun CompleteScreen(
5050

5151
val state by viewModel.collectAsState()
5252

53-
val activity = (LocalContext.current as? Activity)
53+
val activity = LocalActivity.current
5454
val context = LocalContext.current
5555
var inviteClicked by remember {
5656
mutableStateOf(false)

feature/community/presentation/src/main/java/com/bff/wespot/community/component/FilterChip.kt

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ internal fun FilterChip(
8181
Gray700
8282
},
8383
shape = RoundedCornerShape(80.dp),
84-
)
85-
.clickableSingle {
84+
).clickableSingle {
8685
if (selected) {
8786
onSameChipClicked.invoke()
8887
} else {
@@ -125,8 +124,7 @@ internal fun FilterChip(
125124
startX = 0f,
126125
endX = 100f,
127126
),
128-
)
129-
.width(70.dp),
127+
).width(70.dp),
130128
contentAlignment = Alignment.CenterEnd,
131129
) {
132130
Box(
@@ -135,8 +133,7 @@ internal fun FilterChip(
135133
.background(
136134
color = WeSpotThemeManager.colors.cardBackgroundColor,
137135
shape = CircleShape,
138-
)
139-
.size(30.dp)
136+
).size(30.dp)
140137
.clickableSingle {
141138
onMoreClicked.invoke()
142139
},
@@ -156,7 +153,6 @@ internal fun FilterChip(
156153

157154
private fun LazyListState.isScrolledToTheEnd() = layoutInfo.visibleItemsInfo.lastOrNull()?.index == layoutInfo.totalItemsCount - 1
158155

159-
160156
private object FilterChipPreviewData {
161157
val sampleFilterChips = listOf(
162158
FilterChipUiModel(

0 commit comments

Comments
 (0)