Incompatibilities with typescript@4.9

[justinfagnani]

I'm seeing type errors that expressions are not assignable to MetaNode for calls to cloneNode(). I know there have been a lot of compiler API changes since 4.7.

[justinfagnani]

@wessberg I started to look to see if I could dig in here, first by adding tests for 4.9.4.

The tests pass with it, but I'm a bit confused by which tests are running for which versions: the comment tests are running up through 4.9.4, but the clone tests are only running up though 4.8.2, even though the tests ranges look fine and some are even tagged >=4.9. (I'm curious about those as 4.9 wasn't installed as a devDependency yet).

Also, I'm getting are compile errors in my codebase. I suppose it's possible that there are compile errors and not runtime errors with the test suite. Have you though about compiling the tests for each TypeScript version?

[wessberg]

Hey Justin,

First of all - which version of ts-clone-node are you using?

I recently went in and added TypeScript v4.9 support for ts-clone-node, which builds upon CompatFactory that normalizes the API surface for working with TS Node Factories for any TypeScript version, but maybe there's something I've missed somewhere that isn't covered by a test.

I'm curious as to why you're experiencing that only TypeScript versions below v4.9 is running the clone tests, as I'm seeing both locally and via Github actions that all tests are running - and passing - for TypeScript 4.9 as well.

As for the type error you mention, if an Expression is not assignable to MetaNode, which is wrapper around TypeScript's Node interface with some additional nullable properties, that means that whatever you're giving it isn't assignable to Node, so I can only assume that the two types are defined in two different versions of TypeScript. It sounds to me a lot like there's multiple TypeScript versions in play here.

I'm also using ts-clone-node in a few codebases where I'm running TS 4.9, and I haven't run into these types of problems, so we might need to dig a little deeper.

[justinfagnani]

Ok, thanks for the reply @wessberg. I'm in a fairly large monorepo, but I thought I had updated and/or deduped both instances that could be in play. I'll dig in some more.