Skip to content

Commit 9ea23ed

Browse files
committed
Short-circuit in NavGroup.get_active
There is no need to check all conditions, we can short-circuit the method as soon as any one condition is met.
1 parent 05e8992 commit 9ea23ed

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/django_simple_nav/nav.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -240,12 +240,10 @@ def get_url(self) -> str:
240240

241241
@override
242242
def get_active(self, request: HttpRequest) -> bool:
243-
is_active = super().get_active(request)
244-
243+
if super().get_active(request):
244+
return True
245245
items = self.get_items(request)
246-
item_is_active = any([item.get_active(request) for item in items])
247-
248-
return is_active or item_is_active
246+
return any(item.get_active(request) for item in items)
249247

250248
@override
251249
def check_permissions(self, request: HttpRequest) -> bool:

0 commit comments

Comments
 (0)