-
Notifications
You must be signed in to change notification settings - Fork 37
Open
Description
After the security fix in PR #14 incomplete query parameters (e.g. /test?foo=bar& or just /test?) lead to a lockup of the HTTP request parser: in HTTPsReq_Handle the value of RxBufLenRem stays at 1 with just the trailing CR (and LF) at RxBufPtr.
Before the patches RxBufLenRem was 0 at this point.
I'd suggest to add the following line
len_rd += len
here (between lines 1191 and 1193):
uC-HTTP/Server/Source/http-s_req.c
Lines 1191 to 1194 in 80d4004
| if (key_val_pair_len == 0u){ /* In the case it's null, the query has been fully ... */ | |
| *p_err = HTTPs_ERR_NONE; /* ...parsed and it has finished by a '&'. */ | |
| goto exit_update; | |
| } |
Metadata
Metadata
Assignees
Labels
No labels