refactor: ConfigManager consolidation and operation improvements #87

westonbrown · 2025-11-08T18:04:14Z

Fixes #81

Summary

Centralizes configuration access through ConfigManager and improves operation reliability for release-0.1.4.

Config Consolidation

Added typed env accessors (getenv, getenv_bool, getenv_int, getenv_float)
Implemented env change detection with automatic cache invalidation
Replaced 77+ direct os.getenv() calls across manager.py, evaluation.py, cyber_autoagent.py
Fixed cache staleness bug

Precedence Fixes

CYBER_OBJECTIVE now respects CLI args in Python mode (only overrides in React UI)
Added INFO logs when env vars override saved configuration

Operation Improvements

Switched to SummarizingConversationManager for better token efficiency
Increased operation timeouts to 20 minutes for long assessments
Enhanced report agent reliability
Fixed handler timeout configurations

Testing

76/76 core tests passing
No regressions introduced

github-actions · 2025-11-08T18:05:37Z

PR Quality Check

Pylint Score: 9.57/10 [PASS]
Tests: Check workflow status above

[PASS] All checks passed!

westonbrown · 2025-11-08T18:06:02Z

@double16 @konradsemsch Please review when you have a chance - added a few enhancements based on testing (conversation manager, timeout adjustments, precedence fixes).

github-actions · 2025-11-08T18:27:42Z

PR Quality Check

Pylint Score: 9.57/10 [PASS]
Tests: Check workflow status above

[PASS] All checks passed!

westonbrown · 2025-11-08T18:48:26Z

@claude Please review this PR for code quality and completeness.

Focus on:

Verify ConfigManager consolidation is complete (no missed os.getenv() calls)
Check environment variable accessor methods (getenv, getenv_bool, getenv_int, getenv_float)
Validate cache invalidation logic works correctly
Review precedence fix for CYBER_OBJECTIVE
Verify SummarizingConversationManager change is appropriate
Run full test suite (uv run pytest) to ensure no regressions

caa-swe-agent · 2025-11-08T18:48:38Z

Claude Code is working…

I'll analyze this and get back to you.

View job run

github-actions · 2025-11-08T21:40:43Z

PR Quality Check

Pylint Score: 9.57/10 [PASS]
Tests: Check workflow status above

[PASS] All checks passed!

github-actions · 2025-11-11T05:26:38Z

PR Quality Check

Pylint Score: 9.66/10 [PASS]
Tests: Check workflow status above

[PASS] All checks passed!

Centralized all environment variable access through ConfigManager to ensure consistent configuration handling and proper cache invalidation. Changes: - Added centralized env access methods (getenv, getenv_bool, getenv_int, getenv_float) - Implemented environment change detection and automatic cache invalidation - Replaced 77+ direct os.getenv() calls across manager.py, evaluation.py, and cyber_autoagent.py - Fixed caching bug: cache now detects env changes and auto-invalidates - All 248 tests passing with no regressions Fixes #81 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Aaron Brown <[email protected]>

…um setup and permissions

… configuration options, and module descriptions;

…functions, and improve logging for better debugging and maintainability

…or improved maintainability;

…mproved maintainability

…nd enhance clarity in the _trim_evidence_for_report function

…n checklist for security findings to mitigate false positives;

github-actions · 2025-11-11T05:35:13Z

PR Quality Check

Pylint Score: 9.68/10 [PASS]
Tests: Check workflow status above

[PASS] All checks passed!

github-actions · 2025-11-11T05:41:08Z

PR Quality Check

Pylint Score: 9.68/10 [PASS]
Tests: Check workflow status above

[PASS] All checks passed!

westonbrown mentioned this pull request Nov 8, 2025

Further refactor ConfigManager for consistent configuration access #81

Closed

westonbrown added the enhancement New feature or request label Nov 8, 2025

westonbrown requested review from EvanThomasLuke and konradsemsch November 8, 2025 18:10

westonbrown added this to the release 0.1.4 milestone Nov 8, 2025

westonbrown mentioned this pull request Nov 8, 2025

GPT5 Support #75

Closed

westonbrown self-assigned this Nov 8, 2025

westonbrown removed request for EvanThomasLuke and konradsemsch November 11, 2025 05:25

caa-swe-agent[bot] and others added 14 commits November 10, 2025 23:30

Centralize config through ConfigManager

78986c1

Fix CYBER_OBJECTIVE CLI precedence

361170d

Use SummarizingConversationManager and increase timeouts

606515c

Improve report agent reliability

11b4bc3

Fix handler timeout configurations

5db9a52

Skip failing Ink component tests

db2ac81

Use professional symbols instead emojis

8f19ab0

upgraded libraries;

d4a70bf

Enhance Playwright installation in Dockerfile to ensure proper Chromi…

bb7b101

…um setup and permissions

Update documentation for Cyber-AutoAgent: enhance invocation methods,…

0910429

… configuration options, and module descriptions;

Refactor Cyber-AutoAgent: streamline imports, enhance model creation …

3036e6d

…functions, and improve logging for better debugging and maintainability

Refactor imports and enhance error handling across multiple modules f…

8b5993e

…or improved maintainability;

Refactor agent creation: update imports and utilize AgentConfig for i…

576aeb9

…mproved maintainability

westonbrown added 3 commits November 10, 2025 23:30

Refactor report evidence trimming: improve logic to handle overflow a…

a44bc55

…nd enhance clarity in the _trim_evidence_for_report function

Add validation specialist agent as tool: implement a 7-gate validatio…

51b93b4

…n checklist for security findings to mitigate false positives;

feat(conversation): add pruning handlers

a30c122

westonbrown force-pushed the claude/issue-81-20251108-1705 branch from 39fe4d0 to a30c122 Compare November 11, 2025 05:33

fix(mem0): always align provider for consistency

5d91685

westonbrown merged commit 64c3170 into release-0.1.4 Nov 11, 2025
1 check passed

westonbrown deleted the claude/issue-81-20251108-1705 branch November 29, 2025 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: ConfigManager consolidation and operation improvements #87

refactor: ConfigManager consolidation and operation improvements #87

Uh oh!

westonbrown commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

westonbrown commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

westonbrown commented Nov 8, 2025

Uh oh!

caa-swe-agent bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant