Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the configuration to use mise exec (shortened as mise x) for running most tools instead of requiring them to be installed directly in the mise config. This allows tool versions to be specified centrally in the shared hk configuration file rather than in individual mise.toml files.
Key changes:
- Remove prettier from mise.toml tools and add clarifying comment about hk/pkl being for git hooks
- Wrap tool commands with
mise x <tool>[@version] --prefix to enable mise-based execution - Pin specific versions for pkl (0.30.0) and gitleaks (8.30.0) in the shared configuration
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mise.toml | Removes prettier from tools list and clarifies remaining tools are for git hooks |
| Shared.pkl | Adds mise exec wrappers to all tool commands and pins versions for pkl and gitleaks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/autosquash |
we-helper
bot
force-pushed
the
steps-use-mise-x
branch
from
5190473 to
a9cfe74
Compare
...to remove the need to add the tools to the mise config and to be able to specify tool versions in the shared hk configuration.
stempler
force-pushed
the
steps-use-mise-x
branch
from
a9cfe74 to
a86812a
Compare
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...to remove the need to add the tools to the mise config and to be able to specify tool versions in the shared hk configuration.