Skip to content

Commit d72ccf0

Browse files
committed
Avoid stack overflow
refs: #32
1 parent 020176f commit d72ccf0

File tree

4 files changed

+17
-1
lines changed

4 files changed

+17
-1
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,16 @@ jobs:
2323
run: cmake .
2424
- name: build
2525
run: cmake --build . --config Release
26+
27+
asan:
28+
runs-on: ubuntu-latest
29+
strategy:
30+
fail-fast: false
31+
steps:
32+
- uses: actions/checkout@v2
33+
- name: configure
34+
run: cmake -DASAN=on -DCMAKE_BUILD_TYPE=Debug .
35+
- name: build
36+
run: cmake --build .
37+
- name: test
38+
run: tests/test.sh

src/extracts.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1588,7 +1588,7 @@ void APar_Print_TrackDetails(TrackInfo *track_info) {
15881588
}
15891589

15901590
void APar_ExtractDetails(FILE *isofile, uint8_t optional_output) {
1591-
char uint32_buffer[5];
1591+
char uint32_buffer[8];
15921592
Trackage track = {0};
15931593

15941594
AtomicInfo *mvhdAtom = APar_FindAtom("moov.mvhd", false, VERSIONED_ATOM, 0);

tests/issue-32.mp4

1.78 KB
Binary file not shown.

tests/test.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
#!/bin/bash
2+
set -xe
3+
./AtomicParsley ./tests/issue-32.mp4 -T 1 -t +

0 commit comments

Comments
 (0)